diff options
| author | Benjamin Peterson <benjamin@python.org> | 2016-12-29 04:02:35 (GMT) |
|---|---|---|
| committer | Benjamin Peterson <benjamin@python.org> | 2016-12-29 04:02:35 (GMT) |
| commit | acc2f74ca991f6579f5b9055dfe885b9a8af4645 (patch) | |
| tree | e81403eab8acdd2c64d7c5369147fd34e17213bb | |
| parent | 4b1e98b0af68ee80a37618ad599ead194f179cf1 (diff) | |
| download | cpython-acc2f74ca991f6579f5b9055dfe885b9a8af4645.zip cpython-acc2f74ca991f6579f5b9055dfe885b9a8af4645.tar.gz cpython-acc2f74ca991f6579f5b9055dfe885b9a8af4645.tar.bz2 | |
fix error check, so that Random.seed actually uses OS randomness (closes #29085)
| -rw-r--r-- | Misc/NEWS | 3 | ||||
| -rw-r--r-- | Modules/_randommodule.c | 2 |
2 files changed, 4 insertions, 1 deletions
@@ -40,6 +40,9 @@ Core and Builtins Library ------- +- Issue #29085: Allow random.Random.seed() to use high quality OS randomness + rather than the pid and time. + - Issue #29079: Prevent infinite loop in pathlib.resolve() on Windows - Issue #13051: Fixed recursion errors in large or resized diff --git a/Modules/_randommodule.c b/Modules/_randommodule.c index 63759d5..0d3282d 100644 --- a/Modules/_randommodule.c +++ b/Modules/_randommodule.c @@ -245,7 +245,7 @@ random_seed(RandomObject *self, PyObject *args) return NULL; if (arg == NULL || arg == Py_None) { - if (random_seed_urandom(self) >= 0) { + if (random_seed_urandom(self) < 0) { PyErr_Clear(); /* Reading system entropy failed, fall back on the worst entropy: |