summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictor Stinner <victor.stinner@haypocalc.com>2011-05-15 16:57:44 (GMT)
committerVictor Stinner <victor.stinner@haypocalc.com>2011-05-15 16:57:44 (GMT)
commitd0e11ec5b07c7c49061a2e4a73a0c231d9b46ad7 (patch)
tree3b579a69db5721b11b89d9c18aa0ab14272f520e
parent2ec6b176bd0fc41c6d00f244a4d8d6bdefa2c620 (diff)
downloadcpython-d0e11ec5b07c7c49061a2e4a73a0c231d9b46ad7.zip
cpython-d0e11ec5b07c7c49061a2e4a73a0c231d9b46ad7.tar.gz
cpython-d0e11ec5b07c7c49061a2e4a73a0c231d9b46ad7.tar.bz2
Issue #10756: atexit normalizes the exception before displaying it. Patch by
Andreas Stührk. Backport a fix already applied to Python 3.2+ (4a82be47a948 + 5060a92a8597).
-rw-r--r--Lib/test/test_atexit.py8
-rw-r--r--Misc/NEWS3
-rw-r--r--Modules/atexitmodule.c1
3 files changed, 12 insertions, 0 deletions
diff --git a/Lib/test/test_atexit.py b/Lib/test/test_atexit.py
index 8a71036..9c7e109 100644
--- a/Lib/test/test_atexit.py
+++ b/Lib/test/test_atexit.py
@@ -65,6 +65,14 @@ class TestCase(unittest.TestCase):
self.assertRaises(TypeError, atexit._run_exitfuncs)
+ def test_raise_unnormalized(self):
+ # Issue #10756: Make sure that an unnormalized exception is
+ # handled properly
+ atexit.register(lambda: 1 / 0)
+
+ self.assertRaises(ZeroDivisionError, atexit._run_exitfuncs)
+ self.assertIn("ZeroDivisionError", self.stream.getvalue())
+
def test_stress(self):
a = [0]
def inc():
diff --git a/Misc/NEWS b/Misc/NEWS
index c41e475..521a2a0 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -72,6 +72,9 @@ Core and Builtins
Library
-------
+- Issue #10756: atexit normalizes the exception before displaying it. Patch by
+ Andreas Stührk.
+
- Issue #8650: Make zlib module 64-bit clean. compress(), decompress() and
their incremental counterparts now raise OverflowError if given an input
larger than 4GB, instead of silently truncating the input and returning
diff --git a/Modules/atexitmodule.c b/Modules/atexitmodule.c
index 1382133..1ee7ead 100644
--- a/Modules/atexitmodule.c
+++ b/Modules/atexitmodule.c
@@ -72,6 +72,7 @@ atexit_callfuncs(void)
PyErr_Fetch(&exc_type, &exc_value, &exc_tb);
if (!PyErr_ExceptionMatches(PyExc_SystemExit)) {
PySys_WriteStderr("Error in atexit._run_exitfuncs:\n");
+ PyErr_NormalizeException(&exc_type, &exc_value, &exc_tb);
PyErr_Display(exc_type, exc_value, exc_tb);
}
}