diff options
author | Mark Shannon <mark@hotpy.org> | 2021-07-15 14:54:38 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-07-15 14:54:38 (GMT) |
commit | 47695e3c88343e794d37333853b2ba3f16505c5d (patch) | |
tree | d0d21e371cf56948daa5069be6b3f1078c86d55b | |
parent | 2ce8af3cbcb368a35a05a5a9f97a09405124f239 (diff) | |
download | cpython-47695e3c88343e794d37333853b2ba3f16505c5d.zip cpython-47695e3c88343e794d37333853b2ba3f16505c5d.tar.gz cpython-47695e3c88343e794d37333853b2ba3f16505c5d.tar.bz2 |
bpo-44622: Set line number of END_ASYNC_FOR to match that of iterator. (GH-27160) (GH-27163)
(cherry picked from commit f333ab0f2edec26a769ed558263ac662e5475451)
-rw-r--r-- | Lib/test/test_compile.py | 12 | ||||
-rw-r--r-- | Python/compile.c | 4 |
2 files changed, 14 insertions, 2 deletions
diff --git a/Lib/test/test_compile.py b/Lib/test/test_compile.py index 6dc1c38..99ba487 100644 --- a/Lib/test/test_compile.py +++ b/Lib/test/test_compile.py @@ -906,10 +906,20 @@ if 1: genexp_lines = [None, 1, 3, 1] genexp_code = return_genexp.__code__.co_consts[1] - code_lines = [None if line is None else line-return_genexp.__code__.co_firstlineno + code_lines = [ None if line is None else line-return_genexp.__code__.co_firstlineno for (_, _, line) in genexp_code.co_lines() ] self.assertEqual(genexp_lines, code_lines) + def test_line_number_implicit_return_after_async_for(self): + + async def test(aseq): + async for i in aseq: + body + + expected_lines = [None, 1, 2, 1] + code_lines = [ None if line is None else line-test.__code__.co_firstlineno + for (_, _, line) in test.__code__.co_lines() ] + self.assertEqual(expected_lines, code_lines) def test_big_dict_literal(self): # The compiler has a flushing point in "compiler_dict" that calls compiles diff --git a/Python/compile.c b/Python/compile.c index 0508ea1..9b7ce19 100644 --- a/Python/compile.c +++ b/Python/compile.c @@ -2923,7 +2923,9 @@ compiler_async_for(struct compiler *c, stmt_ty s) /* Except block for __anext__ */ compiler_use_next_block(c, except); - c->u->u_lineno = -1; + /* Use same line number as the iterator, + * as the END_ASYNC_FOR succeeds the `for`, not the body. */ + SET_LOC(c, s->v.AsyncFor.iter); ADDOP(c, END_ASYNC_FOR); /* `else` block */ |