diff options
| author | Terry Jan Reedy <tjreedy@udel.edu> | 2019-03-11 00:18:40 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-03-11 00:18:40 (GMT) |
| commit | 491ef53c1548c2b593d3c35d1e7bf25ccb443019 (patch) | |
| tree | 0cf9a3cc3a4057813fc8af4e6a10e7fbec389513 | |
| parent | 0e1f1f01058bd4a9b98cfe443214adecc019a38c (diff) | |
| download | cpython-491ef53c1548c2b593d3c35d1e7bf25ccb443019.zip cpython-491ef53c1548c2b593d3c35d1e7bf25ccb443019.tar.gz cpython-491ef53c1548c2b593d3c35d1e7bf25ccb443019.tar.bz2 | |
bpo-36176: Fix IDLE autocomplete & calltip popup colors. (#12262)
Prevent conflicts with Linux dark themes
(and slightly darken calltip background).
| -rw-r--r-- | Lib/idlelib/NEWS.txt | 6 | ||||
| -rw-r--r-- | Lib/idlelib/autocomplete_w.py | 2 | ||||
| -rw-r--r-- | Lib/idlelib/calltip_w.py | 3 | ||||
| -rw-r--r-- | Misc/NEWS.d/next/IDLE/2019-03-10-00-07-46.bpo-36176.jk_vv6.rst | 2 |
4 files changed, 10 insertions, 3 deletions
diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt index 58050f6..c771dd0 100644 --- a/Lib/idlelib/NEWS.txt +++ b/Lib/idlelib/NEWS.txt @@ -3,7 +3,11 @@ Released on 2019-10-20? ====================================== -bpl-36152: Remove colorizer.ColorDelegator.close_when_done and the +bpo-36176: Fix IDLE autocomplete & calltip popup colors. +Prevent conflicts with Linux dark themes +(and slightly darken calltip background). + +bpo-36152: Remove colorizer.ColorDelegator.close_when_done and the corresponding argument of .close(). In IDLE, both have always been None or False since 2007. diff --git a/Lib/idlelib/autocomplete_w.py b/Lib/idlelib/autocomplete_w.py index 7994bc0..c249625 100644 --- a/Lib/idlelib/autocomplete_w.py +++ b/Lib/idlelib/autocomplete_w.py @@ -189,7 +189,7 @@ class AutoCompleteWindow: pass self.scrollbar = scrollbar = Scrollbar(acw, orient=VERTICAL) self.listbox = listbox = Listbox(acw, yscrollcommand=scrollbar.set, - exportselection=False, bg="white") + exportselection=False) for item in self.completions: listbox.insert(END, item) self.origselforeground = listbox.cget("selectforeground") diff --git a/Lib/idlelib/calltip_w.py b/Lib/idlelib/calltip_w.py index 7553dfe..1e0404a 100644 --- a/Lib/idlelib/calltip_w.py +++ b/Lib/idlelib/calltip_w.py @@ -80,7 +80,8 @@ class CalltipWindow(TooltipBase): def showcontents(self): """Create the call-tip widget.""" self.label = Label(self.tipwindow, text=self.text, justify=LEFT, - background="#ffffe0", relief=SOLID, borderwidth=1, + background="#ffffd0", foreground="black", + relief=SOLID, borderwidth=1, font=self.anchor_widget['font']) self.label.pack() diff --git a/Misc/NEWS.d/next/IDLE/2019-03-10-00-07-46.bpo-36176.jk_vv6.rst b/Misc/NEWS.d/next/IDLE/2019-03-10-00-07-46.bpo-36176.jk_vv6.rst new file mode 100644 index 0000000..5998c6f --- /dev/null +++ b/Misc/NEWS.d/next/IDLE/2019-03-10-00-07-46.bpo-36176.jk_vv6.rst @@ -0,0 +1,2 @@ +Fix IDLE autocomplete & calltip popup colors. Prevent conflicts with Linux +dark themes (and slightly darken calltip background). |