summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGregory P. Smith <greg@krypto.org>2022-04-19 09:31:50 (GMT)
committerGitHub <noreply@github.com>2022-04-19 09:31:50 (GMT)
commit61570ae0bc1507a62bee9d8b9bc2ff7155da7061 (patch)
treee24d45b7377cd92ec5e98047385ffad5f855cd1c
parent0897a0bf9c75bacf428b8f6f08114fffc9f9c542 (diff)
downloadcpython-61570ae0bc1507a62bee9d8b9bc2ff7155da7061.zip
cpython-61570ae0bc1507a62bee9d8b9bc2ff7155da7061.tar.gz
cpython-61570ae0bc1507a62bee9d8b9bc2ff7155da7061.tar.bz2
[3.10] gh-91676 gh-91260 unittest.IsolatedAsyncioTestCase no longer leaks its executor (GH-91680)
For things like test_asyncio.test_thread this was causing frequent "environment modified by test" errors as the executor threads had not always stopped running after the test was over.
-rw-r--r--Lib/unittest/async_case.py2
-rw-r--r--Misc/NEWS.d/next/Library/2022-04-19-04-33-39.gh-issue-91676.ceQBwh.rst4
2 files changed, 6 insertions, 0 deletions
diff --git a/Lib/unittest/async_case.py b/Lib/unittest/async_case.py
index 2323119..d9c694e 100644
--- a/Lib/unittest/async_case.py
+++ b/Lib/unittest/async_case.py
@@ -148,6 +148,8 @@ class IsolatedAsyncioTestCase(TestCase):
# shutdown asyncgens
loop.run_until_complete(loop.shutdown_asyncgens())
finally:
+ # Prevent our executor environment from leaking to future tests.
+ loop.run_until_complete(loop.shutdown_default_executor())
asyncio.set_event_loop(None)
loop.close()
diff --git a/Misc/NEWS.d/next/Library/2022-04-19-04-33-39.gh-issue-91676.ceQBwh.rst b/Misc/NEWS.d/next/Library/2022-04-19-04-33-39.gh-issue-91676.ceQBwh.rst
new file mode 100644
index 0000000..dfbaef4
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2022-04-19-04-33-39.gh-issue-91676.ceQBwh.rst
@@ -0,0 +1,4 @@
+Fix :class:`unittest.IsolatedAsyncioTestCase` to shutdown the per test event
+loop executor before returning from its ``run`` method so that a not yet
+stopped or garbage collected executor state does not persist beyond the
+test.