diff options
author | Georg Brandl <georg@python.org> | 2010-08-01 19:02:09 (GMT) |
---|---|---|
committer | Georg Brandl <georg@python.org> | 2010-08-01 19:02:09 (GMT) |
commit | 0347c71c5f520d1c60f9e3006a0124203a31ec73 (patch) | |
tree | 8f7887934c48e92dc6a561f85a143a362e8f5e78 | |
parent | 78e6957cdf091318e4b31d17008fbaa08fffa6a2 (diff) | |
download | cpython-0347c71c5f520d1c60f9e3006a0124203a31ec73.zip cpython-0347c71c5f520d1c60f9e3006a0124203a31ec73.tar.gz cpython-0347c71c5f520d1c60f9e3006a0124203a31ec73.tar.bz2 |
Merged revisions 83385-83389,83391 via svnmerge from
svn+ssh://pythondev@svn.python.org/python/branches/py3k
........
r83385 | georg.brandl | 2010-08-01 08:42:45 +0200 (So, 01 Aug 2010) | 1 line
#8773: mailbox.py does not need to be executable.
........
r83386 | georg.brandl | 2010-08-01 08:44:46 +0200 (So, 01 Aug 2010) | 1 line
#8768: name test method properly so that it gets executed.
........
r83387 | georg.brandl | 2010-08-01 08:53:28 +0200 (So, 01 Aug 2010) | 1 line
#8735: better explain semantics of *values* argument for parse().
........
r83388 | georg.brandl | 2010-08-01 09:48:43 +0200 (So, 01 Aug 2010) | 1 line
#7395: fix traceback in do_add() when no stats are loaded. Apply same fix for do_sort() and do_reverse().
........
r83389 | georg.brandl | 2010-08-01 09:57:47 +0200 (So, 01 Aug 2010) | 1 line
Small improvements to pstats browser: do not crash on reading invalid file, and actually do a reload when executing "read" as intended.
........
r83391 | georg.brandl | 2010-08-01 10:10:08 +0200 (So, 01 Aug 2010) | 1 line
Add another news entry.
........
-rw-r--r-- | Doc/library/optparse.rst | 5 | ||||
-rw-r--r--[-rwxr-xr-x] | Lib/mailbox.py | 0 | ||||
-rw-r--r-- | Lib/pstats.py | 29 | ||||
-rw-r--r-- | Lib/test/test_set.py | 2 | ||||
-rw-r--r-- | Misc/NEWS | 4 |
5 files changed, 32 insertions, 8 deletions
diff --git a/Doc/library/optparse.rst b/Doc/library/optparse.rst index 9d5b9ff..13649bc 100644 --- a/Doc/library/optparse.rst +++ b/Doc/library/optparse.rst @@ -1238,8 +1238,9 @@ where the input parameters are the list of arguments to process (default: ``sys.argv[1:]``) ``values`` - object to store option arguments in (default: a new instance of - :class:`optparse.Values`) + a :class:`optparse.Values` object to store option arguments in (default: a + new instance of :class:`Values`) -- if you give an existing object, the + option defaults will not be initialized on it and the return values are diff --git a/Lib/mailbox.py b/Lib/mailbox.py index 2b7b14e..2b7b14e 100755..100644 --- a/Lib/mailbox.py +++ b/Lib/mailbox.py diff --git a/Lib/pstats.py b/Lib/pstats.py index 8b60810..59dcf26 100644 --- a/Lib/pstats.py +++ b/Lib/pstats.py @@ -588,7 +588,10 @@ if __name__ == '__main__': print >> self.stream, " that match it are printed." def do_add(self, line): - self.stats.add(line) + if self.stats: + self.stats.add(line) + else: + print >> self.stream, "No statistics object is loaded." return 0 def help_add(self): print >> self.stream, "Add profile info from given file to current statistics object." @@ -623,22 +626,33 @@ if __name__ == '__main__': except IOError, args: print >> self.stream, args[1] return + except Exception as err: + print >> self.stream, err.__class__.__name__ + ':', err + return self.prompt = line + "% " elif len(self.prompt) > 2: - line = self.prompt[-2:] + line = self.prompt[:-2] + self.do_read(line) else: print >> self.stream, "No statistics object is current -- cannot reload." return 0 def help_read(self): print >> self.stream, "Read in profile data from a specified file." + print >> self.stream, "Without argument, reload the current file." def do_reverse(self, line): - self.stats.reverse_order() + if self.stats: + self.stats.reverse_order() + else: + print >> self.stream, "No statistics object is loaded." return 0 def help_reverse(self): print >> self.stream, "Reverse the sort order of the profiling report." def do_sort(self, line): + if not self.stats: + print >> self.stream, "No statistics object is loaded." + return abbrevs = self.stats.get_sort_arg_defs() if line and all((x in abbrevs) for x in line.split()): self.stats.sort_stats(*line.split()) @@ -660,11 +674,16 @@ if __name__ == '__main__': self.generic_help() def do_strip(self, line): - self.stats.strip_dirs() - return 0 + if self.stats: + self.stats.strip_dirs() + else: + print >> self.stream, "No statistics object is loaded." def help_strip(self): print >> self.stream, "Strip leading path information from filenames in the report." + def help_help(self): + print >> self.stream, "Show help for a given command." + def postcmd(self, stop, line): if stop: return stop diff --git a/Lib/test/test_set.py b/Lib/test/test_set.py index 0c29017..e8ccedf 100644 --- a/Lib/test/test_set.py +++ b/Lib/test/test_set.py @@ -750,7 +750,7 @@ class TestBasicOps(unittest.TestCase): result = self.set ^ self.set self.assertEqual(result, empty_set) - def checkempty_symmetric_difference(self): + def test_empty_symmetric_difference(self): result = self.set ^ empty_set self.assertEqual(result, self.set) @@ -27,6 +27,10 @@ Library - Issue #9448: Fix a leak of OS resources (mutexes or semaphores) when re-initializing a buffered IO object by calling its ``__init__`` method. +- Issue #7395: Fix tracebacks in pstats interactive browser. + +- Issue #8230: Fix Lib/test/sortperf.py. + - Issue #1713: Fix os.path.ismount(), which returned true for symbolic links across devices. |