summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEzio Melotti <ezio.melotti@gmail.com>2012-11-03 15:38:43 (GMT)
committerEzio Melotti <ezio.melotti@gmail.com>2012-11-03 15:38:43 (GMT)
commit2cc3b4ba9ffa658784da03f14a0a068e2c61d1b3 (patch)
tree66423060d67ba1f6ad182450edb895cc29ca28f1
parent4552e3f95c3382a4665cb8adab343521f8898331 (diff)
downloadcpython-2cc3b4ba9ffa658784da03f14a0a068e2c61d1b3.zip
cpython-2cc3b4ba9ffa658784da03f14a0a068e2c61d1b3.tar.gz
cpython-2cc3b4ba9ffa658784da03f14a0a068e2c61d1b3.tar.bz2
#16152: fix tokenize to ignore whitespace at the end of the code when no newline is found. Patch by Ned Batchelder.
-rw-r--r--Lib/test/test_tokenize.py5
-rw-r--r--Lib/tokenize.py4
-rw-r--r--Misc/ACKS1
-rw-r--r--Misc/NEWS3
4 files changed, 12 insertions, 1 deletions
diff --git a/Lib/test/test_tokenize.py b/Lib/test/test_tokenize.py
index b6a9ca1..f9652ce 100644
--- a/Lib/test/test_tokenize.py
+++ b/Lib/test/test_tokenize.py
@@ -552,6 +552,11 @@ Evil tabs
DEDENT '' (4, 0) (4, 0)
DEDENT '' (4, 0) (4, 0)
+Pathological whitespace (http://bugs.python.org/issue16152)
+ >>> dump_tokens("@ ")
+ ENCODING 'utf-8' (0, 0) (0, 0)
+ OP '@' (1, 0) (1, 1)
+
Non-ascii identifiers
>>> dump_tokens("Örter = 'places'\\ngrün = 'green'")
diff --git a/Lib/tokenize.py b/Lib/tokenize.py
index 59081d3..29c9e29 100644
--- a/Lib/tokenize.py
+++ b/Lib/tokenize.py
@@ -108,7 +108,7 @@ ContStr = group(r"[bB]?[rR]?'[^\n'\\]*(?:\\.[^\n'\\]*)*" +
group("'", r'\\\r?\n'),
r'[bB]?[rR]?"[^\n"\\]*(?:\\.[^\n"\\]*)*' +
group('"', r'\\\r?\n'))
-PseudoExtras = group(r'\\\r?\n', Comment, Triple)
+PseudoExtras = group(r'\\\r?\n|\Z', Comment, Triple)
PseudoToken = Whitespace + group(PseudoExtras, Number, Funny, ContStr, Name)
def _compile(expr):
@@ -473,6 +473,8 @@ def _tokenize(readline, encoding):
if pseudomatch: # scan for tokens
start, end = pseudomatch.span(1)
spos, epos, pos = (lnum, start), (lnum, end), end
+ if start == end:
+ continue
token, initial = line[start:end], line[start]
if (initial in numchars or # ordinary number
diff --git a/Misc/ACKS b/Misc/ACKS
index a070be8..1095733 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -71,6 +71,7 @@ Des Barry
Ulf Bartelt
Don Bashford
Nick Bastin
+Ned Batchelder
Jeff Bauer
Mike Bayer
Michael R Bax
diff --git a/Misc/NEWS b/Misc/NEWS
index 3075225..3ee301f 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -143,6 +143,9 @@ Core and Builtins
Library
-------
+- Issue #16152: fix tokenize to ignore whitespace at the end of the code when
+ no newline is found. Patch by Ned Batchelder.
+
- Issue #1207589: Add Cut/Copy/Paste items to IDLE right click Context Menu
Patch by Todd Rovito.