summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTerry Jan Reedy <tjreedy@udel.edu>2014-04-16 03:38:18 (GMT)
committerTerry Jan Reedy <tjreedy@udel.edu>2014-04-16 03:38:18 (GMT)
commit6ac4240b6ce55903f05791e1e3f8c4059a6f25a3 (patch)
treebe4086db475288eef637e528b10313d5b62b4067
parent45278a898c0d6ac5a38a07b525fb216d9afa36df (diff)
downloadcpython-6ac4240b6ce55903f05791e1e3f8c4059a6f25a3.zip
cpython-6ac4240b6ce55903f05791e1e3f8c4059a6f25a3.tar.gz
cpython-6ac4240b6ce55903f05791e1e3f8c4059a6f25a3.tar.bz2
Issue #18566: Clarify unittest setUp, tearDown doc. Patch by Nitika Agarwal.
-rw-r--r--Doc/library/unittest.rst14
-rw-r--r--Misc/ACKS1
2 files changed, 8 insertions, 7 deletions
diff --git a/Doc/library/unittest.rst b/Doc/library/unittest.rst
index fbeaf7f..bc61d3f 100644
--- a/Doc/library/unittest.rst
+++ b/Doc/library/unittest.rst
@@ -674,9 +674,9 @@ Test cases
.. method:: setUp()
Method called to prepare the test fixture. This is called immediately
- before calling the test method; any exception raised by this method will
- be considered an error rather than a test failure. The default
- implementation does nothing.
+ before calling the test method; other than :exc:`AssertionError` or :exc:`SkipTest`,
+ any exception raised by this method will be considered an error rather than
+ a test failure. The default implementation does nothing.
.. method:: tearDown()
@@ -684,10 +684,10 @@ Test cases
Method called immediately after the test method has been called and the
result recorded. This is called even if the test method raised an
exception, so the implementation in subclasses may need to be particularly
- careful about checking internal state. Any exception raised by this
- method will be considered an error rather than a test failure. This
- method will only be called if the :meth:`setUp` succeeds, regardless of
- the outcome of the test method. The default implementation does nothing.
+ careful about checking internal state. Any exception, other than :exc:`AssertionError`
+ or :exc:`SkipTest`, raised by this method will be considered an error rather than a
+ test failure. This method will only be called if the :meth:`setUp` succeeds,
+ regardless of the outcome of the test method. The default implementation does nothing.
.. method:: setUpClass()
diff --git a/Misc/ACKS b/Misc/ACKS
index a19a68f..14eabd4 100644
--- a/Misc/ACKS
+++ b/Misc/ACKS
@@ -18,6 +18,7 @@ David Abrahams
Marc Abramowitz
Ron Adam
Ali Afshar
+Nitika Agarwal
Jim Ahlstrom
Farhan Ahmad
Matthew Ahrens