summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMark Dickinson <dickinsm@gmail.com>2009-09-07 18:04:58 (GMT)
committerMark Dickinson <dickinsm@gmail.com>2009-09-07 18:04:58 (GMT)
commit968f1690d39e8c825f9af1b634ff5b5a9517c290 (patch)
tree83dc220e8505efdf3738039831b8b334738740db
parent491ea55f2866cc0b4fee036069fc07748920b0cf (diff)
downloadcpython-968f1690d39e8c825f9af1b634ff5b5a9517c290.zip
cpython-968f1690d39e8c825f9af1b634ff5b5a9517c290.tar.gz
cpython-968f1690d39e8c825f9af1b634ff5b5a9517c290.tar.bz2
#Issue 6795: Fix infinite recursion in long(Decimal('nan')); change int(Decimal('nan')) to raise ValueError instead of either returning NaN or raising InvalidContext.
-rw-r--r--Lib/decimal.py5
-rw-r--r--Lib/test/test_decimal.py10
-rw-r--r--Misc/NEWS4
3 files changed, 16 insertions, 3 deletions
diff --git a/Lib/decimal.py b/Lib/decimal.py
index 1f5c920..a87a4a5 100644
--- a/Lib/decimal.py
+++ b/Lib/decimal.py
@@ -1555,10 +1555,9 @@ class Decimal(object):
"""Converts self to an int, truncating if necessary."""
if self._is_special:
if self._isnan():
- context = getcontext()
- return context._raise_error(InvalidContext)
+ raise ValueError("Cannot convert NaN to integer")
elif self._isinfinity():
- raise OverflowError("Cannot convert infinity to int")
+ raise OverflowError("Cannot convert infinity to integer")
s = (-1)**self._sign
if self._exp >= 0:
return s*int(self._int)*10**self._exp
diff --git a/Lib/test/test_decimal.py b/Lib/test/test_decimal.py
index f7f023d..50a855e 100644
--- a/Lib/test/test_decimal.py
+++ b/Lib/test/test_decimal.py
@@ -1489,6 +1489,16 @@ class DecimalPythonAPItests(unittest.TestCase):
r = d.to_integral(ROUND_DOWN)
self.assertEqual(Decimal(int(d)), r)
+ self.assertRaises(ValueError, int, Decimal('-nan'))
+ self.assertRaises(ValueError, int, Decimal('snan'))
+ self.assertRaises(OverflowError, int, Decimal('inf'))
+ self.assertRaises(OverflowError, int, Decimal('-inf'))
+
+ self.assertRaises(ValueError, long, Decimal('-nan'))
+ self.assertRaises(ValueError, long, Decimal('snan'))
+ self.assertRaises(OverflowError, long, Decimal('inf'))
+ self.assertRaises(OverflowError, long, Decimal('-inf'))
+
def test_trunc(self):
for x in range(-250, 250):
s = '%0.2f' % (x / 100.0)
diff --git a/Misc/NEWS b/Misc/NEWS
index fe281cf..daea539 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -366,6 +366,10 @@ Core and Builtins
Library
-------
+- Issue #6795: int(Decimal('nan')) now raises ValueError instead of
+ returning NaN or raising InvalidContext. Also, fix infinite recursion
+ in long(Decimal('nan')).
+
- Issue #6850: Fix bug in Decimal._parse_format_specifier for formats
with no type specifier.