summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthias Bussonnier <bussonniermatthias@gmail.com>2018-05-17 08:16:12 (GMT)
committerSerhiy Storchaka <storchaka@gmail.com>2018-05-17 08:16:12 (GMT)
commitf90f5d5c1d95721e0ca0b1c302e3d13ed34753a8 (patch)
tree6cfb0f3881f6d5aa7c775be2efe09d01eca1df3d
parentd5f144260886959c1fe06bc4506a23fd10f92348 (diff)
downloadcpython-f90f5d5c1d95721e0ca0b1c302e3d13ed34753a8.zip
cpython-f90f5d5c1d95721e0ca0b1c302e3d13ed34753a8.tar.gz
cpython-f90f5d5c1d95721e0ca0b1c302e3d13ed34753a8.tar.bz2
bpo-33549: Remove shim and deprecation warning to access DocumentLS.async. (GH-6924)
`obj.async` is now a syntax error, so the warning/shim is quasi-unnecessary.
-rw-r--r--Lib/test/test_minidom.py10
-rw-r--r--Lib/xml/dom/xmlbuilder.py22
2 files changed, 0 insertions, 32 deletions
diff --git a/Lib/test/test_minidom.py b/Lib/test/test_minidom.py
index ee8c041..a2cc882 100644
--- a/Lib/test/test_minidom.py
+++ b/Lib/test/test_minidom.py
@@ -60,17 +60,7 @@ class MinidomTest(unittest.TestCase):
def testDocumentAsyncAttr(self):
doc = Document()
self.assertFalse(doc.async_)
- with self.assertWarns(DeprecationWarning):
- self.assertFalse(getattr(doc, 'async', True))
- with self.assertWarns(DeprecationWarning):
- setattr(doc, 'async', True)
- with self.assertWarns(DeprecationWarning):
- self.assertTrue(getattr(doc, 'async', False))
- self.assertTrue(doc.async_)
-
self.assertFalse(Document.async_)
- with self.assertWarns(DeprecationWarning):
- self.assertFalse(getattr(Document, 'async', True))
def testParseFromBinaryFile(self):
with open(tstfile, 'rb') as file:
diff --git a/Lib/xml/dom/xmlbuilder.py b/Lib/xml/dom/xmlbuilder.py
index 60a2bc3..213ab14 100644
--- a/Lib/xml/dom/xmlbuilder.py
+++ b/Lib/xml/dom/xmlbuilder.py
@@ -332,29 +332,10 @@ class DOMBuilderFilter:
del NodeFilter
-class _AsyncDeprecatedProperty:
- def warn(self, cls):
- clsname = cls.__name__
- warnings.warn(
- "{cls}.async is deprecated; use {cls}.async_".format(cls=clsname),
- DeprecationWarning)
-
- def __get__(self, instance, cls):
- self.warn(cls)
- if instance is not None:
- return instance.async_
- return False
-
- def __set__(self, instance, value):
- self.warn(type(instance))
- setattr(instance, 'async_', value)
-
-
class DocumentLS:
"""Mixin to create documents that conform to the load/save spec."""
async_ = False
- locals()['async'] = _AsyncDeprecatedProperty() # Avoid DeprecationWarning
def _get_async(self):
return False
@@ -384,9 +365,6 @@ class DocumentLS:
return snode.toxml()
-del _AsyncDeprecatedProperty
-
-
class DOMImplementationLS:
MODE_SYNCHRONOUS = 1
MODE_ASYNCHRONOUS = 2