summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMark Dickinson <dickinsm@gmail.com>2013-07-20 16:59:13 (GMT)
committerMark Dickinson <dickinsm@gmail.com>2013-07-20 16:59:13 (GMT)
commit58ceecfe5ac0ad436d556b589870dd2df62731c0 (patch)
treeb9303a76865599bf1dec6fb4626b22573419cfc9
parent7ed4294d7f821a0733ab47285317f06a8c51e5db (diff)
downloadcpython-58ceecfe5ac0ad436d556b589870dd2df62731c0.zip
cpython-58ceecfe5ac0ad436d556b589870dd2df62731c0.tar.gz
cpython-58ceecfe5ac0ad436d556b589870dd2df62731c0.tar.bz2
Issue #18513: Add workaround for OS X 10.8 cexp bug that leads to wrong cmath.rect(0.0,-0.0) results.
-rw-r--r--Misc/NEWS3
-rw-r--r--Modules/cmathmodule.c7
2 files changed, 10 insertions, 0 deletions
diff --git a/Misc/NEWS b/Misc/NEWS
index de16f7b..f79f625 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -49,6 +49,9 @@ Core and Builtins
Library
-------
+- Issue #18513: Fix behaviour of cmath.rect w.r.t. signed zeros on OS X 10.8 +
+ gcc.
+
- Issue #18480: Add missing call to PyType_Ready to the _elementtree extension.
- Issue #17778: Fix test discovery for test_multiprocessing. (Patch by
diff --git a/Modules/cmathmodule.c b/Modules/cmathmodule.c
index 3021cf0..36bf4a1 100644
--- a/Modules/cmathmodule.c
+++ b/Modules/cmathmodule.c
@@ -1006,6 +1006,13 @@ cmath_rect(PyObject *self, PyObject *args)
else
errno = 0;
}
+ else if (phi == 0.0) {
+ /* Workaround for buggy results with phi=-0.0 on OS X 10.8. See
+ bugs.python.org/issue18513. */
+ z.real = r;
+ z.imag = r * phi;
+ errno = 0;
+ }
else {
z.real = r * cos(phi);
z.imag = r * sin(phi);