diff options
| author | Georg Brandl <georg@python.org> | 2008-03-21 20:46:11 (GMT) |
|---|---|---|
| committer | Georg Brandl <georg@python.org> | 2008-03-21 20:46:11 (GMT) |
| commit | 896c317b43260451b3773d905b8fc90027ea50bf (patch) | |
| tree | 5bd4da0e3762e67b00ea6d926af85fba67223495 | |
| parent | 38889804086855d507ca5cfee187e8c91fc99379 (diff) | |
| download | cpython-896c317b43260451b3773d905b8fc90027ea50bf.zip cpython-896c317b43260451b3773d905b8fc90027ea50bf.tar.gz cpython-896c317b43260451b3773d905b8fc90027ea50bf.tar.bz2 | |
Add XXX comments for whoever cleans up getargs.c :)
| -rw-r--r-- | Python/getargs.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/Python/getargs.c b/Python/getargs.c index abe0887..1370e09 100644 --- a/Python/getargs.c +++ b/Python/getargs.c @@ -823,6 +823,9 @@ convertsimple(PyObject *arg, const char **p_format, va_list *p_va, int flags, } else return converterr("string", arg, msgbuf, bufsize); + /* XXX(gb): this test is completely wrong -- p is a + * byte string while arg is a Unicode. I *think* it should + * check against the size of uarg... */ if ((Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg)) return converterr("string without null bytes", arg, msgbuf, bufsize); @@ -898,6 +901,7 @@ convertsimple(PyObject *arg, const char **p_format, va_list *p_va, int flags, } format++; } + /* XXX(gb): same comment as for 's' applies here... */ else if (*p != NULL && (Py_ssize_t)strlen(*p) != PyUnicode_GetSize(arg)) return converterr( |