summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSenthil Kumaran <senthil@uthcode.com>2011-10-19 17:05:44 (GMT)
committerSenthil Kumaran <senthil@uthcode.com>2011-10-19 17:05:44 (GMT)
commit1ef0c0349e8fdb5415e21231cb42edbf232b742a (patch)
tree04ac9f390298a474255f8a36983d7db4d1e46dd9
parente130a52d8a60229f53c8bc2ea7a1f51ee592bbd7 (diff)
downloadcpython-1ef0c0349e8fdb5415e21231cb42edbf232b742a.zip
cpython-1ef0c0349e8fdb5415e21231cb42edbf232b742a.tar.gz
cpython-1ef0c0349e8fdb5415e21231cb42edbf232b742a.tar.bz2
3.2 - Fix closes Issue12529 - cgi.parse_header failure on double quotes and
semicolons. Patch by Ben Darnell and Petri Lehtinen.
-rwxr-xr-xLib/cgi.py2
-rw-r--r--Lib/test/test_cgi.py4
2 files changed, 5 insertions, 1 deletions
diff --git a/Lib/cgi.py b/Lib/cgi.py
index e198ed8..90a3345 100755
--- a/Lib/cgi.py
+++ b/Lib/cgi.py
@@ -291,7 +291,7 @@ def _parseparam(s):
while s[:1] == ';':
s = s[1:]
end = s.find(';')
- while end > 0 and s.count('"', 0, end) % 2:
+ while end > 0 and (s.count('"', 0, end) - s.count('\\"', 0, end)) % 2:
end = s.find(';', end + 1)
if end < 0:
end = len(s)
diff --git a/Lib/test/test_cgi.py b/Lib/test/test_cgi.py
index c42db4e..9951e93 100644
--- a/Lib/test/test_cgi.py
+++ b/Lib/test/test_cgi.py
@@ -348,6 +348,10 @@ this is the content of the fake file
self.assertEqual(
cgi.parse_header('attachment; filename="strange;name";size=123;'),
("attachment", {"filename": "strange;name", "size": "123"}))
+ self.assertEqual(
+ cgi.parse_header('form-data; name="files"; filename="fo\\"o;bar"'),
+ ("form-data", {"name": "files", "filename": 'fo"o;bar'}))
+
BOUNDARY = "---------------------------721837373350705526688164684"