summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAntoine Pitrou <solipsis@pitrou.net>2012-05-14 17:45:27 (GMT)
committerAntoine Pitrou <solipsis@pitrou.net>2012-05-14 17:45:27 (GMT)
commite2eab5e768ca7bd44788ec6c499cf12e9fa52435 (patch)
tree3b98b5178a7ab06a7ccc14b18fe748a028b97cee
parent4043d3dee28c4257c7bf27f0a581a2212665066f (diff)
parent072e4a3fc7cdca935309b713a01ea1c318a95508 (diff)
downloadcpython-e2eab5e768ca7bd44788ec6c499cf12e9fa52435.zip
cpython-e2eab5e768ca7bd44788ec6c499cf12e9fa52435.tar.gz
cpython-e2eab5e768ca7bd44788ec6c499cf12e9fa52435.tar.bz2
Followup to issue #14157: respect the relative ordering of values produced by time.strptime().
Patch by Hynek.
-rw-r--r--Lib/_strptime.py8
-rw-r--r--Lib/test/test_strptime.py5
2 files changed, 13 insertions, 0 deletions
diff --git a/Lib/_strptime.py b/Lib/_strptime.py
index 0106e91..fa06376 100644
--- a/Lib/_strptime.py
+++ b/Lib/_strptime.py
@@ -444,8 +444,10 @@ def _strptime(data_string, format="%a %b %d %H:%M:%S %Y"):
else:
tz = value
break
+ leap_year_fix = False
if year is None and month == 2 and day == 29:
year = 1904 # 1904 is first leap year of 20th century
+ leap_year_fix = True
elif year is None:
year = 1900
# If we know the week of the year and what day of that week, we can figure
@@ -476,6 +478,12 @@ def _strptime(data_string, format="%a %b %d %H:%M:%S %Y"):
else:
gmtoff = None
+ if leap_year_fix:
+ # the caller didn't supply a year but asked for Feb 29th. We couldn't
+ # use the default of 1900 for computations. We set it back to ensure
+ # that February 29th is smaller than March 1st.
+ year = 1900
+
return (year, month, day,
hour, minute, second,
weekday, julian, tz, gmtoff, tzname), fraction
diff --git a/Lib/test/test_strptime.py b/Lib/test/test_strptime.py
index 7245671..90aac5b 100644
--- a/Lib/test/test_strptime.py
+++ b/Lib/test/test_strptime.py
@@ -381,6 +381,11 @@ class StrptimeTests(unittest.TestCase):
def test_feb29_on_leap_year_without_year(self):
time.strptime("Feb 29", "%b %d")
+ def test_mar1_comes_after_feb29_even_when_omitting_the_year(self):
+ self.assertLess(
+ time.strptime("Feb 29", "%b %d"),
+ time.strptime("Mar 1", "%b %d"))
+
class Strptime12AMPMTests(unittest.TestCase):
"""Test a _strptime regression in '%I %p' at 12 noon (12 PM)"""