diff options
| author | Gregory P. Smith <greg@krypto.org> | 2021-06-03 03:43:38 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-06-03 03:43:38 (GMT) |
| commit | e60ab843cbb016fb6ff8b4f418641ac05a9b2fcc (patch) | |
| tree | 4ab4a08d9c050b6d21c07bfbb7f5c38a47d33fbf | |
| parent | adef445dc34685648bd0ea1c125df2ef143912ed (diff) | |
| download | cpython-e60ab843cbb016fb6ff8b4f418641ac05a9b2fcc.zip cpython-e60ab843cbb016fb6ff8b4f418641ac05a9b2fcc.tar.gz cpython-e60ab843cbb016fb6ff8b4f418641ac05a9b2fcc.tar.bz2 | |
bpo-44022: Improve the regression test. (GH-26503)
It wasn't actually detecting the regression due to the
assertion being too lenient.
| -rw-r--r-- | Lib/test/test_httplib.py | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/Lib/test/test_httplib.py b/Lib/test/test_httplib.py index e927256..8265b8d 100644 --- a/Lib/test/test_httplib.py +++ b/Lib/test/test_httplib.py @@ -1186,7 +1186,12 @@ class BasicTest(TestCase): 'r\n' * 32768 ) resp = client.HTTPResponse(FakeSocket(body)) - self.assertRaises(client.HTTPException, resp.begin) + with self.assertRaises(client.HTTPException) as cm: + resp.begin() + # We must assert more because other reasonable errors that we + # do not want can also be HTTPException derived. + self.assertIn('got more than ', str(cm.exception)) + self.assertIn('headers', str(cm.exception)) def test_overflowing_chunked_line(self): body = ( |