diff options
author | Irit Katriel <1055913+iritkatriel@users.noreply.github.com> | 2022-05-04 18:40:47 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-05-04 18:40:47 (GMT) |
commit | e61330b44f22b11a71f5bbcc17e309dd80e3e95f (patch) | |
tree | 8c820414bd1cb991e3607df4806ab48d807f0dc7 | |
parent | f8a2fab212c4e9ea92a5b667560449904c4cf7af (diff) | |
download | cpython-e61330b44f22b11a71f5bbcc17e309dd80e3e95f.zip cpython-e61330b44f22b11a71f5bbcc17e309dd80e3e95f.tar.gz cpython-e61330b44f22b11a71f5bbcc17e309dd80e3e95f.tar.bz2 |
gh-92118: fix traceback of exceptions propagated from inside a contextlib.contextmanager (GH-92202)
-rw-r--r-- | Lib/contextlib.py | 3 | ||||
-rw-r--r-- | Lib/test/test_contextlib.py | 27 | ||||
-rw-r--r-- | Misc/NEWS.d/next/Library/2022-05-02-23-08-02.gh-issue-92118.9Mm9g4.rst | 1 |
3 files changed, 31 insertions, 0 deletions
diff --git a/Lib/contextlib.py b/Lib/contextlib.py index 4cff9c6..625bb33 100644 --- a/Lib/contextlib.py +++ b/Lib/contextlib.py @@ -161,6 +161,7 @@ class _GeneratorContextManager( except RuntimeError as exc: # Don't re-raise the passed in exception. (issue27122) if exc is value: + exc.__traceback__ = traceback return False # Avoid suppressing if a StopIteration exception # was passed to throw() and later wrapped into a RuntimeError @@ -172,6 +173,7 @@ class _GeneratorContextManager( isinstance(value, StopIteration) and exc.__cause__ is value ): + exc.__traceback__ = traceback return False raise except BaseException as exc: @@ -183,6 +185,7 @@ class _GeneratorContextManager( # and the __exit__() protocol. if exc is not value: raise + exc.__traceback__ = traceback return False raise RuntimeError("generator didn't stop after throw()") diff --git a/Lib/test/test_contextlib.py b/Lib/test/test_contextlib.py index e238548..bfe8117 100644 --- a/Lib/test/test_contextlib.py +++ b/Lib/test/test_contextlib.py @@ -5,6 +5,7 @@ import os import sys import tempfile import threading +import traceback import unittest from contextlib import * # Tests __all__ from test import support @@ -87,6 +88,32 @@ class ContextManagerTestCase(unittest.TestCase): raise ZeroDivisionError() self.assertEqual(state, [1, 42, 999]) + def test_contextmanager_traceback(self): + @contextmanager + def f(): + yield + + try: + with f(): + 1/0 + except ZeroDivisionError as e: + frames = traceback.extract_tb(e.__traceback__) + + self.assertEqual(len(frames), 1) + self.assertEqual(frames[0].name, 'test_contextmanager_traceback') + self.assertEqual(frames[0].line, '1/0') + + # Repeat with RuntimeError (which goes through a different code path) + try: + with f(): + raise NotImplementedError(42) + except NotImplementedError as e: + frames = traceback.extract_tb(e.__traceback__) + + self.assertEqual(len(frames), 1) + self.assertEqual(frames[0].name, 'test_contextmanager_traceback') + self.assertEqual(frames[0].line, 'raise NotImplementedError(42)') + def test_contextmanager_no_reraise(self): @contextmanager def whee(): diff --git a/Misc/NEWS.d/next/Library/2022-05-02-23-08-02.gh-issue-92118.9Mm9g4.rst b/Misc/NEWS.d/next/Library/2022-05-02-23-08-02.gh-issue-92118.9Mm9g4.rst new file mode 100644 index 0000000..b58ecdf --- /dev/null +++ b/Misc/NEWS.d/next/Library/2022-05-02-23-08-02.gh-issue-92118.9Mm9g4.rst @@ -0,0 +1 @@ +Fix a 3.11 regression in :func:`~contextlib.contextmanager`, which caused it to propagate exceptions with incorrect tracebacks. |