summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGeorg Brandl <georg@python.org>2011-08-13 09:48:40 (GMT)
committerGeorg Brandl <georg@python.org>2011-08-13 09:48:40 (GMT)
commit74b6abf61f88221c4c859623a75655dcb214e072 (patch)
tree610a8d7af5e56d45f94ed888adc7e2844b9dbc00
parent3672c4e21f4a886306070512354443f229c5cd0e (diff)
parent3abb372c810c13af4207124c175cfd0a842b5f56 (diff)
downloadcpython-74b6abf61f88221c4c859623a75655dcb214e072.zip
cpython-74b6abf61f88221c4c859623a75655dcb214e072.tar.gz
cpython-74b6abf61f88221c4c859623a75655dcb214e072.tar.bz2
Merge with 3.2.
-rw-r--r--Lib/tarfile.py6
-rw-r--r--Lib/test/test_tarfile.py8
-rw-r--r--Misc/NEWS3
3 files changed, 15 insertions, 2 deletions
diff --git a/Lib/tarfile.py b/Lib/tarfile.py
index bd92ded..6bdbf36 100644
--- a/Lib/tarfile.py
+++ b/Lib/tarfile.py
@@ -1802,11 +1802,13 @@ class TarFile(object):
fileobj = gzip.GzipFile(name, mode + "b", compresslevel, fileobj)
t = cls.taropen(name, mode, fileobj, **kwargs)
except IOError:
- if not extfileobj:
+ if not extfileobj and fileobj is not None:
fileobj.close()
+ if fileobj is None:
+ raise
raise ReadError("not a gzip file")
except:
- if not extfileobj:
+ if not extfileobj and fileobj is not None:
fileobj.close()
raise
t._extfileobj = extfileobj
diff --git a/Lib/test/test_tarfile.py b/Lib/test/test_tarfile.py
index d65e1b5..38a5027 100644
--- a/Lib/test/test_tarfile.py
+++ b/Lib/test/test_tarfile.py
@@ -1682,6 +1682,14 @@ class LinkEmulationTest(ReadTest):
class GzipMiscReadTest(MiscReadTest):
tarname = gzipname
mode = "r:gz"
+
+ def test_non_existent_targz_file(self):
+ # Test for issue11513: prevent non-existent gzipped tarfiles raising
+ # multiple exceptions.
+ with self.assertRaisesRegex(IOError, "xxx") as ex:
+ tarfile.open("xxx", self.mode)
+ self.assertEqual(ex.exception.errno, errno.ENOENT)
+
class GzipUstarReadTest(UstarReadTest):
tarname = gzipname
mode = "r:gz"
diff --git a/Misc/NEWS b/Misc/NEWS
index 360e731..112badf 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -254,6 +254,9 @@ Core and Builtins
Library
-------
+- Issue #11513: Fix exception handling ``tarfile.TarFile.gzopen()`` when
+ the file cannot be opened.
+
- Issue #12687: Fix a possible buffering bug when unpickling text mode
(protocol 0, mostly) pickles.