summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPablo Galindo <Pablogsal@gmail.com>2021-05-15 16:58:02 (GMT)
committerGitHub <noreply@github.com>2021-05-15 16:58:02 (GMT)
commit80b089179fa798c8ceaab2ff699c82499b2fcacd (patch)
tree9b1be535d529b1e25c22695c9a8d818360575662
parent086b5c6ce16b524629428b4fd5c9213930bfca47 (diff)
downloadcpython-80b089179fa798c8ceaab2ff699c82499b2fcacd.zip
cpython-80b089179fa798c8ceaab2ff699c82499b2fcacd.tar.gz
cpython-80b089179fa798c8ceaab2ff699c82499b2fcacd.tar.bz2
bpo-44143: Fix crash in the parser when raising tokenizer errors with an exception set (GH-26144)
-rw-r--r--Lib/test/test_exceptions.py1
-rw-r--r--Misc/NEWS.d/next/Core and Builtins/2021-05-15-17-30-57.bpo-44143.7UTS6H.rst2
-rw-r--r--Parser/pegen.c1
3 files changed, 4 insertions, 0 deletions
diff --git a/Lib/test/test_exceptions.py b/Lib/test/test_exceptions.py
index 1fe479f..aefdd7b 100644
--- a/Lib/test/test_exceptions.py
+++ b/Lib/test/test_exceptions.py
@@ -242,6 +242,7 @@ class ExceptionTests(unittest.TestCase):
""", 9, 24)
check("pass\npass\npass\n(1+)\npass\npass\npass", 4, 4)
check("(1+)", 1, 4)
+ check("[interesting\nfoo()\n", 1, 1)
# Errors thrown by symtable.c
check('x = [(yield i) for i in range(3)]', 1, 5)
diff --git a/Misc/NEWS.d/next/Core and Builtins/2021-05-15-17-30-57.bpo-44143.7UTS6H.rst b/Misc/NEWS.d/next/Core and Builtins/2021-05-15-17-30-57.bpo-44143.7UTS6H.rst
new file mode 100644
index 0000000..a4e88e5
--- /dev/null
+++ b/Misc/NEWS.d/next/Core and Builtins/2021-05-15-17-30-57.bpo-44143.7UTS6H.rst
@@ -0,0 +1,2 @@
+Fixed a crash in the parser that manifest when raising tokenizer errors when
+an existing exception was present. Patch by Pablo Galindo.
diff --git a/Parser/pegen.c b/Parser/pegen.c
index 6080cec..c2f2540 100644
--- a/Parser/pegen.c
+++ b/Parser/pegen.c
@@ -1259,6 +1259,7 @@ _PyPegen_check_tokenizer_errors(Parser *p) {
if (p->tok->level != 0) {
int error_lineno = p->tok->parenlinenostack[p->tok->level-1];
if (current_err_line > error_lineno) {
+ PyErr_Clear();
raise_unclosed_parentheses_error(p);
return -1;
}