summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictor Stinner <victor.stinner@gmail.com>2016-08-19 15:12:23 (GMT)
committerVictor Stinner <victor.stinner@gmail.com>2016-08-19 15:12:23 (GMT)
commit8a31c820930536ffe3b44d99252ba9f3bb98ce58 (patch)
treed5952e59fdcb67329576d4ce63b258e844716546
parent0d1a799343dd956c8e4a1d6e0ac3fa9ac007704e (diff)
downloadcpython-8a31c820930536ffe3b44d99252ba9f3bb98ce58.zip
cpython-8a31c820930536ffe3b44d99252ba9f3bb98ce58.tar.gz
cpython-8a31c820930536ffe3b44d99252ba9f3bb98ce58.tar.bz2
Fix PyObject_Call() parameter names
Issue #27128: arg=>args, kw=>kwargs. Same change for PyEval_CallObjectWithKeywords().
-rw-r--r--Include/abstract.h2
-rw-r--r--Include/ceval.h2
-rw-r--r--Objects/abstract.c6
-rw-r--r--Python/ceval.c25
4 files changed, 19 insertions, 16 deletions
diff --git a/Include/abstract.h b/Include/abstract.h
index 280402c..f67c6b2 100644
--- a/Include/abstract.h
+++ b/Include/abstract.h
@@ -264,7 +264,7 @@ xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx*/
*/
PyAPI_FUNC(PyObject *) PyObject_Call(PyObject *callable_object,
- PyObject *args, PyObject *kw);
+ PyObject *args, PyObject *kwargs);
#ifndef Py_LIMITED_API
PyAPI_FUNC(PyObject*) _PyStack_AsTuple(PyObject **stack,
diff --git a/Include/ceval.h b/Include/ceval.h
index d194044..73b4ca6 100644
--- a/Include/ceval.h
+++ b/Include/ceval.h
@@ -8,7 +8,7 @@ extern "C" {
/* Interface to random parts in ceval.c */
PyAPI_FUNC(PyObject *) PyEval_CallObjectWithKeywords(
- PyObject *, PyObject *, PyObject *);
+ PyObject *func, PyObject *args, PyObject *kwargs);
/* Inline this */
#define PyEval_CallObject(func,arg) \
diff --git a/Objects/abstract.c b/Objects/abstract.c
index aaa6fc8..dcf3eb5 100644
--- a/Objects/abstract.c
+++ b/Objects/abstract.c
@@ -2194,7 +2194,7 @@ _Py_CheckFunctionResult(PyObject *func, PyObject *result, const char *where)
}
PyObject *
-PyObject_Call(PyObject *func, PyObject *arg, PyObject *kw)
+PyObject_Call(PyObject *func, PyObject *args, PyObject *kwargs)
{
ternaryfunc call;
PyObject *result;
@@ -2203,6 +2203,8 @@ PyObject_Call(PyObject *func, PyObject *arg, PyObject *kw)
because it may clear it (directly or indirectly) and so the
caller loses its exception */
assert(!PyErr_Occurred());
+ assert(PyTuple_Check(args));
+ assert(kwargs == NULL || PyDict_Check(kwargs));
call = func->ob_type->tp_call;
if (call == NULL) {
@@ -2214,7 +2216,7 @@ PyObject_Call(PyObject *func, PyObject *arg, PyObject *kw)
if (Py_EnterRecursiveCall(" while calling a Python object"))
return NULL;
- result = (*call)(func, arg, kw);
+ result = (*call)(func, args, kwargs);
Py_LeaveRecursiveCall();
diff --git a/Python/ceval.c b/Python/ceval.c
index 75eaa81..905859e 100644
--- a/Python/ceval.c
+++ b/Python/ceval.c
@@ -4580,7 +4580,7 @@ PyEval_MergeCompilerFlags(PyCompilerFlags *cf)
The arg must be a tuple or NULL. The kw must be a dict or NULL. */
PyObject *
-PyEval_CallObjectWithKeywords(PyObject *func, PyObject *arg, PyObject *kw)
+PyEval_CallObjectWithKeywords(PyObject *func, PyObject *args, PyObject *kwargs)
{
PyObject *result;
@@ -4591,32 +4591,33 @@ PyEval_CallObjectWithKeywords(PyObject *func, PyObject *arg, PyObject *kw)
assert(!PyErr_Occurred());
#endif
- if (arg == NULL) {
- if (kw == NULL) {
+ if (args == NULL) {
+ if (kwargs == NULL) {
return _PyObject_FastCall(func, NULL, 0, 0);
}
- arg = PyTuple_New(0);
- if (arg == NULL)
+ args = PyTuple_New(0);
+ if (args == NULL)
return NULL;
}
- else if (!PyTuple_Check(arg)) {
+ else if (!PyTuple_Check(args)) {
PyErr_SetString(PyExc_TypeError,
"argument list must be a tuple");
return NULL;
}
- else
- Py_INCREF(arg);
+ else {
+ Py_INCREF(args);
+ }
- if (kw != NULL && !PyDict_Check(kw)) {
+ if (kwargs != NULL && !PyDict_Check(kwargs)) {
PyErr_SetString(PyExc_TypeError,
"keyword list must be a dictionary");
- Py_DECREF(arg);
+ Py_DECREF(args);
return NULL;
}
- result = PyObject_Call(func, arg, kw);
- Py_DECREF(arg);
+ result = PyObject_Call(func, args, kwargs);
+ Py_DECREF(args);
return result;
}