summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGregory Beauregard <greg@greg.red>2022-02-08 07:46:58 (GMT)
committerGitHub <noreply@github.com>2022-02-08 07:46:58 (GMT)
commitc8b62bbe46e20d4b6dd556f2fa85960d1269aa45 (patch)
tree34296f484dcc9a4a346de4a93b22b0578c2d4703
parente959dd9f5c1d8865d4e10c49eb30ee0a4fe2735d (diff)
downloadcpython-c8b62bbe46e20d4b6dd556f2fa85960d1269aa45.zip
cpython-c8b62bbe46e20d4b6dd556f2fa85960d1269aa45.tar.gz
cpython-c8b62bbe46e20d4b6dd556f2fa85960d1269aa45.tar.bz2
bpo-46676: Make ParamSpec args and kwargs equal to themselves (GH-31203)
-rw-r--r--Lib/test/test_typing.py8
-rw-r--r--Lib/typing.py10
-rw-r--r--Misc/NEWS.d/next/Library/2022-02-07-19-20-42.bpo-46676.3Aws1o.rst1
3 files changed, 19 insertions, 0 deletions
diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py
index a37bb43..4d1c50c 100644
--- a/Lib/test/test_typing.py
+++ b/Lib/test/test_typing.py
@@ -4965,12 +4965,20 @@ class ParamSpecTests(BaseTestCase):
def test_args_kwargs(self):
P = ParamSpec('P')
+ P_2 = ParamSpec('P_2')
self.assertIn('args', dir(P))
self.assertIn('kwargs', dir(P))
self.assertIsInstance(P.args, ParamSpecArgs)
self.assertIsInstance(P.kwargs, ParamSpecKwargs)
self.assertIs(P.args.__origin__, P)
self.assertIs(P.kwargs.__origin__, P)
+ self.assertEqual(P.args, P.args)
+ self.assertEqual(P.kwargs, P.kwargs)
+ self.assertNotEqual(P.args, P_2.args)
+ self.assertNotEqual(P.kwargs, P_2.kwargs)
+ self.assertNotEqual(P.args, P.kwargs)
+ self.assertNotEqual(P.kwargs, P.args)
+ self.assertNotEqual(P.args, P_2.kwargs)
self.assertEqual(repr(P.args), "P.args")
self.assertEqual(repr(P.kwargs), "P.kwargs")
diff --git a/Lib/typing.py b/Lib/typing.py
index d1d5130..0ee5c85 100644
--- a/Lib/typing.py
+++ b/Lib/typing.py
@@ -859,6 +859,11 @@ class ParamSpecArgs(_Final, _Immutable, _root=True):
def __repr__(self):
return f"{self.__origin__.__name__}.args"
+ def __eq__(self, other):
+ if not isinstance(other, ParamSpecArgs):
+ return NotImplemented
+ return self.__origin__ == other.__origin__
+
class ParamSpecKwargs(_Final, _Immutable, _root=True):
"""The kwargs for a ParamSpec object.
@@ -878,6 +883,11 @@ class ParamSpecKwargs(_Final, _Immutable, _root=True):
def __repr__(self):
return f"{self.__origin__.__name__}.kwargs"
+ def __eq__(self, other):
+ if not isinstance(other, ParamSpecKwargs):
+ return NotImplemented
+ return self.__origin__ == other.__origin__
+
class ParamSpec(_Final, _Immutable, _TypeVarLike, _root=True):
"""Parameter specification variable.
diff --git a/Misc/NEWS.d/next/Library/2022-02-07-19-20-42.bpo-46676.3Aws1o.rst b/Misc/NEWS.d/next/Library/2022-02-07-19-20-42.bpo-46676.3Aws1o.rst
new file mode 100644
index 0000000..408412e
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2022-02-07-19-20-42.bpo-46676.3Aws1o.rst
@@ -0,0 +1 @@
+Make :data:`typing.ParamSpec` args and kwargs equal to themselves. Patch by Gregory Beauregard.