diff options
| author | Eric Snow <ericsnowcurrently@gmail.com> | 2015-06-03 17:09:48 (GMT) |
|---|---|---|
| committer | Eric Snow <ericsnowcurrently@gmail.com> | 2015-06-03 17:09:48 (GMT) |
| commit | db4061cb9d3c2a369fa49a3820ffc11854119da3 (patch) | |
| tree | f8eea93c40b584046d5b0ca1f42e2f6da75bcfbd | |
| parent | 4c72918a598393e376b0a3c596348cabac886cca (diff) | |
| download | cpython-db4061cb9d3c2a369fa49a3820ffc11854119da3.zip cpython-db4061cb9d3c2a369fa49a3820ffc11854119da3.tar.gz cpython-db4061cb9d3c2a369fa49a3820ffc11854119da3.tar.bz2 | |
Issue #24377: Fix a ref leak in OrderedDict.__repr__.
| -rw-r--r-- | Misc/NEWS | 2 | ||||
| -rw-r--r-- | Objects/odictobject.c | 2 |
2 files changed, 3 insertions, 1 deletions
@@ -25,6 +25,8 @@ Library - Issue #24362: Simplify the C OrderedDict fast nodes resize logic. +- Issue #24377: Fix a ref leak in OrderedDict.__repr__. + What's New in Python 3.5.0 beta 2? ================================== diff --git a/Objects/odictobject.c b/Objects/odictobject.c index 79ac826..55055ac 100644 --- a/Objects/odictobject.c +++ b/Objects/odictobject.c @@ -1578,7 +1578,7 @@ odict_repr(PyODictObject *self) if (value == NULL) { if (!PyErr_Occurred()) PyErr_SetObject(PyExc_KeyError, key); - return NULL; + goto Done; } pair = PyTuple_Pack(2, key, value); if (pair == NULL) |