summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSteve Dower <steve.dower@python.org>2019-10-18 07:52:15 (GMT)
committerMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>2019-10-18 07:52:15 (GMT)
commitfbe3c76c7ce1eec887d332d801d3784212cc0f73 (patch)
treedbce9bfee8d42b70198b81fd003f693829041721
parentb1fa72a5b7e8666a40b6899d5d54778a2a42c3e8 (diff)
downloadcpython-fbe3c76c7ce1eec887d332d801d3784212cc0f73.zip
cpython-fbe3c76c7ce1eec887d332d801d3784212cc0f73.tar.gz
cpython-fbe3c76c7ce1eec887d332d801d3784212cc0f73.tar.bz2
bpo-38418: Fixes audit event for os.system to be named 'os.system' (GH-16670)
https://bugs.python.org/issue38418 Automerge-Triggered-By: @zooba
-rw-r--r--Misc/NEWS.d/next/Security/2019-10-08-19-29-55.bpo-38418.QL7s0-.rst1
-rw-r--r--Modules/posixmodule.c4
2 files changed, 3 insertions, 2 deletions
diff --git a/Misc/NEWS.d/next/Security/2019-10-08-19-29-55.bpo-38418.QL7s0-.rst b/Misc/NEWS.d/next/Security/2019-10-08-19-29-55.bpo-38418.QL7s0-.rst
new file mode 100644
index 0000000..b42a000
--- /dev/null
+++ b/Misc/NEWS.d/next/Security/2019-10-08-19-29-55.bpo-38418.QL7s0-.rst
@@ -0,0 +1 @@
+Fixes audit event for :func:`os.system` to be named ``os.system``.
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
index 3c4e254..6864970 100644
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -4324,7 +4324,7 @@ os_system_impl(PyObject *module, const Py_UNICODE *command)
{
long result;
- if (PySys_Audit("system", "(u)", command) < 0) {
+ if (PySys_Audit("os.system", "(u)", command) < 0) {
return -1;
}
@@ -4351,7 +4351,7 @@ os_system_impl(PyObject *module, PyObject *command)
long result;
const char *bytes = PyBytes_AsString(command);
- if (PySys_Audit("system", "(O)", command) < 0) {
+ if (PySys_Audit("os.system", "(O)", command) < 0) {
return -1;
}