summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Heller <theller@ctypes.org>2006-09-07 18:56:28 (GMT)
committerThomas Heller <theller@ctypes.org>2006-09-07 18:56:28 (GMT)
commitfdb62f0e5f0b7d1a70a9d8948768ff09ea420c41 (patch)
tree5dae99a7d879e5000f2a4e846c8f766287a4b62f
parent863f3d1fbff6b65eb0526f2d98a6f89474b96eb9 (diff)
downloadcpython-fdb62f0e5f0b7d1a70a9d8948768ff09ea420c41.zip
cpython-fdb62f0e5f0b7d1a70a9d8948768ff09ea420c41.tar.gz
cpython-fdb62f0e5f0b7d1a70a9d8948768ff09ea420c41.tar.bz2
Anonymous structure fields that have a bit-width specified did not work,
and they gave a strange error message from PyArg_ParseTuple: function takes exactly 2 arguments (3 given). With tests.
-rw-r--r--Lib/ctypes/test/test_bitfields.py9
-rw-r--r--Modules/_ctypes/stgdict.c4
2 files changed, 11 insertions, 2 deletions
diff --git a/Lib/ctypes/test/test_bitfields.py b/Lib/ctypes/test/test_bitfields.py
index 92c4669..2867cbf 100644
--- a/Lib/ctypes/test/test_bitfields.py
+++ b/Lib/ctypes/test/test_bitfields.py
@@ -215,5 +215,14 @@ class BitFieldTest(unittest.TestCase):
("b", c_ubyte, 4)]
self.failUnlessEqual(sizeof(X), sizeof(c_byte))
+ def test_anon_bitfields(self):
+ # anonymous bit-fields gave a strange error message
+ class X(Structure):
+ _fields_ = [("a", c_byte, 4),
+ ("b", c_ubyte, 4)]
+ class Y(Structure):
+ _anonymous_ = ["_"]
+ _fields_ = [("_", X)]
+
if __name__ == "__main__":
unittest.main()
diff --git a/Modules/_ctypes/stgdict.c b/Modules/_ctypes/stgdict.c
index 182b9af..d701f9e 100644
--- a/Modules/_ctypes/stgdict.c
+++ b/Modules/_ctypes/stgdict.c
@@ -177,11 +177,11 @@ MakeFields(PyObject *type, CFieldObject *descr,
for (i = 0; i < PySequence_Fast_GET_SIZE(fieldlist); ++i) {
PyObject *pair = PySequence_Fast_GET_ITEM(fieldlist, i); /* borrowed */
- PyObject *fname, *ftype;
+ PyObject *fname, *ftype, *bits;
CFieldObject *fdescr;
CFieldObject *new_descr;
/* Convert to PyArg_UnpackTuple... */
- if (!PyArg_ParseTuple(pair, "OO", &fname, &ftype)) {
+ if (!PyArg_ParseTuple(pair, "OO|O", &fname, &ftype, &bits)) {
Py_DECREF(fieldlist);
return -1;
}