diff options
author | Terry Jan Reedy <tjreedy@udel.edu> | 2022-09-24 21:38:58 (GMT) |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-09-24 21:38:58 (GMT) |
commit | 9704f8da333a51da32318f16106d45abb20fab76 (patch) | |
tree | f5c0dfebfd0ce5981c4212068c8b311e793bbb03 | |
parent | db39050396a104c73d0da473a2f00a62f9dfdfaa (diff) | |
download | cpython-9704f8da333a51da32318f16106d45abb20fab76.zip cpython-9704f8da333a51da32318f16106d45abb20fab76.tar.gz cpython-9704f8da333a51da32318f16106d45abb20fab76.tar.bz2 |
gh-97527: IDLE: protect macosx Tk() call when no GUI (#97530)
Only call tkinter.tk and its follow-up code in _init_tk_type when requires('gui')
does not raise. This function can be called as an unintended side-effect of
calling other idlelib code as part of tests on macOS without a GUI enabled.
-rw-r--r-- | Lib/idlelib/macosx.py | 30 |
1 files changed, 17 insertions, 13 deletions
diff --git a/Lib/idlelib/macosx.py b/Lib/idlelib/macosx.py index 53848fb..12399f1 100644 --- a/Lib/idlelib/macosx.py +++ b/Lib/idlelib/macosx.py @@ -4,6 +4,7 @@ A number of functions that enhance IDLE on macOS. from os.path import expanduser import plistlib from sys import platform # Used in _init_tk_type, changed by test. +from test.support import requires, ResourceDenied import tkinter @@ -14,23 +15,26 @@ import tkinter _tk_type = None def _init_tk_type(): - """ - Initializes OS X Tk variant values for - isAquaTk(), isCarbonTk(), isCocoaTk(), and isXQuartz(). + """ Initialize _tk_type for isXyzTk functions. """ global _tk_type if platform == 'darwin': - root = tkinter.Tk() - ws = root.tk.call('tk', 'windowingsystem') - if 'x11' in ws: - _tk_type = "xquartz" - elif 'aqua' not in ws: - _tk_type = "other" - elif 'AppKit' in root.tk.call('winfo', 'server', '.'): - _tk_type = "cocoa" + try: + requires('gui') + except ResourceDenied: # Possible when testing. + _tk_type = "cocoa" # Newest and most common. else: - _tk_type = "carbon" - root.destroy() + root = tkinter.Tk() + ws = root.tk.call('tk', 'windowingsystem') + if 'x11' in ws: + _tk_type = "xquartz" + elif 'aqua' not in ws: + _tk_type = "other" + elif 'AppKit' in root.tk.call('winfo', 'server', '.'): + _tk_type = "cocoa" + else: + _tk_type = "carbon" + root.destroy() else: _tk_type = "other" |