summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenjamin Peterson <benjamin@python.org>2016-09-29 06:17:04 (GMT)
committerBenjamin Peterson <benjamin@python.org>2016-09-29 06:17:04 (GMT)
commit095e32bfc511ee823af3752507c7211a305c8c00 (patch)
treeabed207a15f07cd102153e46d8d2050ef305e525
parent6a8e1ea80c2f2e8334b659f208fa3798219aebea (diff)
parent4254e8c5484460b9be7e58dc89bd25815612fc37 (diff)
downloadcpython-095e32bfc511ee823af3752507c7211a305c8c00.zip
cpython-095e32bfc511ee823af3752507c7211a305c8c00.tar.gz
cpython-095e32bfc511ee823af3752507c7211a305c8c00.tar.bz2
merge 3.5 (#1703178)
-rw-r--r--Lib/distutils/command/build_ext.py1
-rw-r--r--Lib/distutils/tests/test_build_ext.py7
-rw-r--r--Misc/NEWS3
3 files changed, 11 insertions, 0 deletions
diff --git a/Lib/distutils/command/build_ext.py b/Lib/distutils/command/build_ext.py
index 5e51ae4..74de782 100644
--- a/Lib/distutils/command/build_ext.py
+++ b/Lib/distutils/command/build_ext.py
@@ -166,6 +166,7 @@ class build_ext(Command):
self.include_dirs.append(plat_py_include)
self.ensure_string_list('libraries')
+ self.ensure_string_list('link_objects')
# Life is easier if we're not forever checking for None, so
# simplify these options to empty lists if unset
diff --git a/Lib/distutils/tests/test_build_ext.py b/Lib/distutils/tests/test_build_ext.py
index 47b586c..6be0ca2 100644
--- a/Lib/distutils/tests/test_build_ext.py
+++ b/Lib/distutils/tests/test_build_ext.py
@@ -194,6 +194,13 @@ class BuildExtTestCase(TempdirManager,
cmd.finalize_options()
self.assertEqual(cmd.rpath, ['one', 'two'])
+ # make sure cmd.link_objects is turned into a list
+ # if it's a string
+ cmd = build_ext(dist)
+ cmd.link_objects = 'one two,three'
+ cmd.finalize_options()
+ self.assertEqual(cmd.link_objects, ['one', 'two', 'three'])
+
# XXX more tests to perform for win32
# make sure define is turned into 2-tuples
diff --git a/Misc/NEWS b/Misc/NEWS
index 00af6f6..4f5e53f 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -350,6 +350,9 @@ Library
pickling and text representation purposes. Patch by Emanuel Barry and
Serhiy Storchaka.
+- Issue #1703178: Fix the ability to pass the --link-objects option to the
+ distutils build_ext command.
+
- Issue #28019: itertools.count() no longer rounds non-integer step in range
between 1.0 and 2.0 to 1.