summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGeorg Brandl <georg@python.org>2006-06-14 06:08:31 (GMT)
committerGeorg Brandl <georg@python.org>2006-06-14 06:08:31 (GMT)
commit2605ca8773ebf37c840c191a903f168942521aa8 (patch)
treea2c87ca7a34e35404b378cc38e15540ca83b6186
parentd825143be1118ba7e320661b3a71d8822ae5d600 (diff)
downloadcpython-2605ca8773ebf37c840c191a903f168942521aa8.zip
cpython-2605ca8773ebf37c840c191a903f168942521aa8.tar.gz
cpython-2605ca8773ebf37c840c191a903f168942521aa8.tar.bz2
Bug #1339007: Shelf objects now don't raise an exception in their
__del__ method when initialization failed.
-rw-r--r--Lib/shelve.py3
-rw-r--r--Misc/NEWS3
2 files changed, 6 insertions, 0 deletions
diff --git a/Lib/shelve.py b/Lib/shelve.py
index 4959c26..7a75445 100644
--- a/Lib/shelve.py
+++ b/Lib/shelve.py
@@ -139,6 +139,9 @@ class Shelf(UserDict.DictMixin):
self.dict = 0
def __del__(self):
+ if not hasattr(self, 'writeback'):
+ # __init__ didn't succeed, so don't bother closing
+ return
self.close()
def sync(self):
diff --git a/Misc/NEWS b/Misc/NEWS
index 3dbecd7..630d36b 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -156,6 +156,9 @@ Extension Modules
Library
-------
+- Bug #1339007: Shelf objects now don't raise an exception in their
+ __del__ method when initialization failed.
+
- Patch #1455898: The MBCS codec now supports the incremental mode for
double-byte encodings.