summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorWalter Dörwald <walter@livinglogic.de>2019-07-18 18:37:13 (GMT)
committerEthan Furman <ethan@stoneleaf.us>2019-07-18 18:37:13 (GMT)
commit323842c2792a81e87917790506ec3457832c84b3 (patch)
treeded0113edade7ad0aff9373f1cff4a0ab25254e3
parentaf2f5b1723b95e45e1f15b5bd52102b7de560f7c (diff)
downloadcpython-323842c2792a81e87917790506ec3457832c84b3.zip
cpython-323842c2792a81e87917790506ec3457832c84b3.tar.gz
cpython-323842c2792a81e87917790506ec3457832c84b3.tar.bz2
bpo-34443: Use __qualname__ instead of __name__ in enum exception messages. (GH-14809)
* Use __qualname__ instead of __name__ in enum exception messages.
-rw-r--r--Lib/enum.py8
-rw-r--r--Lib/test/test_enum.py13
-rw-r--r--Misc/NEWS.d/next/Library/2019-07-17-11-10-08.bpo-34443.OFnGqz.rst2
3 files changed, 13 insertions, 10 deletions
diff --git a/Lib/enum.py b/Lib/enum.py
index 69a7f49..8f82a6d 100644
--- a/Lib/enum.py
+++ b/Lib/enum.py
@@ -577,7 +577,7 @@ class Enum(metaclass=EnumMeta):
if isinstance(result, cls):
return result
else:
- ve_exc = ValueError("%r is not a valid %s" % (value, cls.__name__))
+ ve_exc = ValueError("%r is not a valid %s" % (value, cls.__qualname__))
if result is None and exc is None:
raise ve_exc
elif exc is None:
@@ -599,7 +599,7 @@ class Enum(metaclass=EnumMeta):
@classmethod
def _missing_(cls, value):
- raise ValueError("%r is not a valid %s" % (value, cls.__name__))
+ raise ValueError("%r is not a valid %s" % (value, cls.__qualname__))
def __repr__(self):
return "<%s.%s: %r>" % (
@@ -706,7 +706,7 @@ class Flag(Enum):
# verify all bits are accounted for
_, extra_flags = _decompose(cls, value)
if extra_flags:
- raise ValueError("%r is not a valid %s" % (value, cls.__name__))
+ raise ValueError("%r is not a valid %s" % (value, cls.__qualname__))
# construct a singleton enum pseudo-member
pseudo_member = object.__new__(cls)
pseudo_member._name_ = None
@@ -780,7 +780,7 @@ class IntFlag(int, Flag):
@classmethod
def _missing_(cls, value):
if not isinstance(value, int):
- raise ValueError("%r is not a valid %s" % (value, cls.__name__))
+ raise ValueError("%r is not a valid %s" % (value, cls.__qualname__))
new_member = cls._create_pseudo_member_(value)
return new_member
diff --git a/Lib/test/test_enum.py b/Lib/test/test_enum.py
index fcfa7d9..7bccd66 100644
--- a/Lib/test/test_enum.py
+++ b/Lib/test/test_enum.py
@@ -2260,12 +2260,13 @@ class TestFlag(unittest.TestCase):
d = 4
f = 6
# Bizarre.c | Bizarre.d
- self.assertRaisesRegex(ValueError, "5 is not a valid Bizarre", Bizarre, 5)
- self.assertRaisesRegex(ValueError, "5 is not a valid Bizarre", Bizarre, 5)
- self.assertRaisesRegex(ValueError, "2 is not a valid Bizarre", Bizarre, 2)
- self.assertRaisesRegex(ValueError, "2 is not a valid Bizarre", Bizarre, 2)
- self.assertRaisesRegex(ValueError, "1 is not a valid Bizarre", Bizarre, 1)
- self.assertRaisesRegex(ValueError, "1 is not a valid Bizarre", Bizarre, 1)
+ name = "TestFlag.test_cascading_failure.<locals>.Bizarre"
+ self.assertRaisesRegex(ValueError, "5 is not a valid " + name, Bizarre, 5)
+ self.assertRaisesRegex(ValueError, "5 is not a valid " + name, Bizarre, 5)
+ self.assertRaisesRegex(ValueError, "2 is not a valid " + name, Bizarre, 2)
+ self.assertRaisesRegex(ValueError, "2 is not a valid " + name, Bizarre, 2)
+ self.assertRaisesRegex(ValueError, "1 is not a valid " + name, Bizarre, 1)
+ self.assertRaisesRegex(ValueError, "1 is not a valid " + name, Bizarre, 1)
def test_duplicate_auto(self):
class Dupes(Enum):
diff --git a/Misc/NEWS.d/next/Library/2019-07-17-11-10-08.bpo-34443.OFnGqz.rst b/Misc/NEWS.d/next/Library/2019-07-17-11-10-08.bpo-34443.OFnGqz.rst
new file mode 100644
index 0000000..8987a79
--- /dev/null
+++ b/Misc/NEWS.d/next/Library/2019-07-17-11-10-08.bpo-34443.OFnGqz.rst
@@ -0,0 +1,2 @@
+Exceptions from :mod:`enum` now use the ``__qualname`` of the enum class in
+the exception message instead of the ``__name__``.