diff options
| author | Victor Stinner <vstinner@python.org> | 2020-01-29 14:23:29 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-01-29 14:23:29 (GMT) |
| commit | 3cb49b62e61208efcefbc04414e769fc173f205d (patch) | |
| tree | 1149c196aa8cc3fbe45f47ff8d910ad2117fd236 | |
| parent | 35eac4500a8bd89b087407f59ba337343b22d403 (diff) | |
| download | cpython-3cb49b62e61208efcefbc04414e769fc173f205d.zip cpython-3cb49b62e61208efcefbc04414e769fc173f205d.tar.gz cpython-3cb49b62e61208efcefbc04414e769fc173f205d.tar.bz2 | |
bpo-39460: Fix test_zipfile.test_add_file_after_2107() (GH-18247)
XFS filesystem is limited to 32-bit timestamp, but the utimensat()
syscall doesn't fail. Moreover, there is a VFS bug which returns
a cached timestamp which is different than the value on disk.
https://bugzilla.redhat.com/show_bug.cgi?id=1795576
https://bugs.python.org/issue39460#msg360952
| -rw-r--r-- | Lib/test/test_zipfile.py | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/Lib/test/test_zipfile.py b/Lib/test/test_zipfile.py index 66f05ac..4c20bfd 100644 --- a/Lib/test/test_zipfile.py +++ b/Lib/test/test_zipfile.py @@ -616,6 +616,18 @@ class StoredTestsWithSourceFile(AbstractTestsWithSourceFile, except OverflowError: self.skipTest('Host fs cannot set timestamp to required value.') + mtime_ns = os.stat(TESTFN).st_mtime_ns + if mtime_ns != (4386268800 * 10**9): + # XFS filesystem is limited to 32-bit timestamp, but the syscall + # didn't fail. Moreover, there is a VFS bug which returns + # a cached timestamp which is different than the value on disk. + # + # Test st_mtime_ns rather than st_mtime to avoid rounding issues. + # + # https://bugzilla.redhat.com/show_bug.cgi?id=1795576 + # https://bugs.python.org/issue39460#msg360952 + self.skipTest(f"Linux VFS/XFS kernel bug detected: {mtime_ns=}") + with zipfile.ZipFile(TESTFN2, "w") as zipfp: self.assertRaises(struct.error, zipfp.write, TESTFN) |