diff options
| author | lekma <lekmalek@gmail.com> | 2018-05-02 09:29:10 (GMT) |
|---|---|---|
| committer | INADA Naoki <methane@users.noreply.github.com> | 2018-05-02 09:29:10 (GMT) |
| commit | 491bbedc209fea314a04cb3015da68fb0aa63238 (patch) | |
| tree | b5914373e115eea5b7581a5c715bb2404fe26c1b | |
| parent | fc6aa28bfd0502d994cec30bd3679b7def3be2af (diff) | |
| download | cpython-491bbedc209fea314a04cb3015da68fb0aa63238.zip cpython-491bbedc209fea314a04cb3015da68fb0aa63238.tar.gz cpython-491bbedc209fea314a04cb3015da68fb0aa63238.tar.bz2 | |
bpo-33391: Fix refleak in set_symmetric_difference (GH-6670)
| -rw-r--r-- | Misc/NEWS.d/next/Core and Builtins/2018-05-02-08-36-03.bpo-33391.z4a7rb.rst | 1 | ||||
| -rw-r--r-- | Objects/setobject.c | 4 |
2 files changed, 4 insertions, 1 deletions
diff --git a/Misc/NEWS.d/next/Core and Builtins/2018-05-02-08-36-03.bpo-33391.z4a7rb.rst b/Misc/NEWS.d/next/Core and Builtins/2018-05-02-08-36-03.bpo-33391.z4a7rb.rst new file mode 100644 index 0000000..ab17aa4 --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2018-05-02-08-36-03.bpo-33391.z4a7rb.rst @@ -0,0 +1 @@ +Fix a leak in set_symmetric_difference(). diff --git a/Objects/setobject.c b/Objects/setobject.c index 80101dd..82b5838 100644 --- a/Objects/setobject.c +++ b/Objects/setobject.c @@ -1744,8 +1744,10 @@ set_symmetric_difference(PySetObject *so, PyObject *other) if (otherset == NULL) return NULL; rv = set_symmetric_difference_update(otherset, (PyObject *)so); - if (rv == NULL) + if (rv == NULL) { + Py_DECREF(otherset); return NULL; + } Py_DECREF(rv); return (PyObject *)otherset; } |