diff options
author | Steve Dower <steve.dower@microsoft.com> | 2015-10-08 16:55:49 (GMT) |
---|---|---|
committer | Steve Dower <steve.dower@microsoft.com> | 2015-10-08 16:55:49 (GMT) |
commit | 5ae56919ab46e07e9bd6e5530cddac75e0276505 (patch) | |
tree | 66c98bd4f60c21dc9772d1dc2925dd048627e272 | |
parent | 3cc6da2b07a8aa78ec53a3ff5ea8d620f4753db6 (diff) | |
download | cpython-5ae56919ab46e07e9bd6e5530cddac75e0276505.zip cpython-5ae56919ab46e07e9bd6e5530cddac75e0276505.tar.gz cpython-5ae56919ab46e07e9bd6e5530cddac75e0276505.tar.bz2 |
Issue #25089: Adds logging to installer for case where launcher is not selected on upgrade.
-rw-r--r-- | Misc/NEWS | 3 | ||||
-rw-r--r-- | Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp | 7 |
2 files changed, 10 insertions, 0 deletions
@@ -297,6 +297,9 @@ Build Windows ------- +- Issue #25089: Adds logging to installer for case where launcher is not + selected on upgrade. + - Issue #25165: Windows uninstallation should not remove launcher if other versions remain diff --git a/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp b/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp index 99884e4..bc418e0 100644 --- a/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp +++ b/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp @@ -687,6 +687,13 @@ public: // IBootstrapperApplication if (hr == S_FALSE) { hr = LoadLauncherStateFromKey(_engine, HKEY_LOCAL_MACHINE); } + if (FAILED(hr)) { + BalLog( + BOOTSTRAPPER_LOG_LEVEL_ERROR, + "Failed to load launcher state: error code 0x%08X", + hr + ); + } } else if (BOOTSTRAPPER_RELATED_OPERATION_NONE == operation) { if (_command.action == BOOTSTRAPPER_ACTION_INSTALL) { LOC_STRING *pLocString = nullptr; |