summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Snow <ericsnowcurrently@gmail.com>2014-04-19 06:13:23 (GMT)
committerEric Snow <ericsnowcurrently@gmail.com>2014-04-19 06:13:23 (GMT)
commit658af3137237407549e71cc1c3a3dd4f2c86b675 (patch)
tree5966ba969f867c851131bc67f68936ac3f6b23f0
parentbddecc386123409c6b16cf931c1b175ded07bfcd (diff)
downloadcpython-658af3137237407549e71cc1c3a3dd4f2c86b675.zip
cpython-658af3137237407549e71cc1c3a3dd4f2c86b675.tar.gz
cpython-658af3137237407549e71cc1c3a3dd4f2c86b675.tar.bz2
Issue #21200: Return None from pkgutil.get_loader() when __spec__ is missing.
-rw-r--r--Lib/pkgutil.py2
-rw-r--r--Lib/test/test_pkgutil.py19
-rw-r--r--Misc/NEWS2
3 files changed, 22 insertions, 1 deletions
diff --git a/Lib/pkgutil.py b/Lib/pkgutil.py
index 58cccdc..e42b6eb 100644
--- a/Lib/pkgutil.py
+++ b/Lib/pkgutil.py
@@ -461,6 +461,8 @@ def get_loader(module_or_name):
loader = getattr(module, '__loader__', None)
if loader is not None:
return loader
+ if getattr(module, '__spec__', None) is None:
+ return None
fullname = module.__name__
else:
fullname = module_or_name
diff --git a/Lib/test/test_pkgutil.py b/Lib/test/test_pkgutil.py
index c4410a9..9704156 100644
--- a/Lib/test/test_pkgutil.py
+++ b/Lib/test/test_pkgutil.py
@@ -1,4 +1,4 @@
-from test.support import run_unittest, unload, check_warnings
+from test.support import run_unittest, unload, check_warnings, CleanImport
import unittest
import sys
import importlib
@@ -345,6 +345,23 @@ class ImportlibMigrationTests(unittest.TestCase):
finally:
__loader__ = this_loader
+ def test_get_loader_handles_missing_spec_attribute(self):
+ name = 'spam'
+ mod = type(sys)(name)
+ del mod.__spec__
+ with CleanImport(name):
+ sys.modules[name] = mod
+ loader = pkgutil.get_loader(name)
+ self.assertIsNone(loader)
+
+ def test_get_loader_handles_spec_attribute_none(self):
+ name = 'spam'
+ mod = type(sys)(name)
+ mod.__spec__ = None
+ with CleanImport(name):
+ sys.modules[name] = mod
+ loader = pkgutil.get_loader(name)
+ self.assertIsNone(loader)
def test_find_loader_avoids_emulation(self):
with check_warnings() as w:
diff --git a/Misc/NEWS b/Misc/NEWS
index 7ef569d..3e121af 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -86,6 +86,8 @@ Library
:func:`tempfile.NamedTemporaryFile`, close the file descriptor if
:func:`io.open` fails
+- Issue #21200: Return None from pkgutil.get_loader() when __spec__ is missing.
+
- Issue #21013: Enhance ssl.create_default_context() when used for server side
sockets to provide better security by default.