diff options
| author | Raymond Hettinger <python@rcn.com> | 2015-08-26 15:08:38 (GMT) |
|---|---|---|
| committer | Raymond Hettinger <python@rcn.com> | 2015-08-26 15:08:38 (GMT) |
| commit | 87674ec7d51eb99586231fbd6469b10d1f4fa111 (patch) | |
| tree | a7230d39fc7176fcb1957713e819643bfe37cca1 | |
| parent | 9783e443bc0d653fcec508c501486f7f8ec39668 (diff) | |
| download | cpython-87674ec7d51eb99586231fbd6469b10d1f4fa111.zip cpython-87674ec7d51eb99586231fbd6469b10d1f4fa111.tar.gz cpython-87674ec7d51eb99586231fbd6469b10d1f4fa111.tar.bz2 | |
Issue #24913: Fix overrun error in deque.index().
| -rw-r--r-- | Lib/test/test_deque.py | 5 | ||||
| -rw-r--r-- | Misc/NEWS | 3 | ||||
| -rw-r--r-- | Modules/_collectionsmodule.c | 2 |
3 files changed, 10 insertions, 0 deletions
diff --git a/Lib/test/test_deque.py b/Lib/test/test_deque.py index b858509..8718716 100644 --- a/Lib/test/test_deque.py +++ b/Lib/test/test_deque.py @@ -289,6 +289,11 @@ class TestBasic(unittest.TestCase): else: self.assertEqual(d.index(element, start, stop), target) + def test_insert_bug_24913(self): + d = deque('A' * 3) + with self.assertRaises(ValueError): + i = d.index("Hello world", 0, 4) + def test_insert(self): # Test to make sure insert behaves like lists elements = 'ABCDEFGHI' @@ -18,6 +18,9 @@ Library header in part headers. Patch written by Peter Landry and reviewed by Pierre Quentel. +- Issue #24913: Fix overrun error in deque.index(). + Found by John Leitch and Bryce Darling. + - Issue #24774: Fix docstring in http.server.test. Patch from Chiu-Hsiang Hsu. - Issue #21159: Improve message in configparser.InterpolationMissingOptionError. diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c index 830c5b8..3856d83 100644 --- a/Modules/_collectionsmodule.c +++ b/Modules/_collectionsmodule.c @@ -924,6 +924,8 @@ deque_index(dequeobject *deque, PyObject *args) if (stop < 0) stop = 0; } + if (stop > Py_SIZE(deque)) + stop = Py_SIZE(deque); for (i=0 ; i<stop ; i++) { if (i >= start) { |