diff options
author | Victor Stinner <victor.stinner@gmail.com> | 2014-01-25 13:37:50 (GMT) |
---|---|---|
committer | Victor Stinner <victor.stinner@gmail.com> | 2014-01-25 13:37:50 (GMT) |
commit | 933209689e8d07e3ce00c68ca26e001b130f0b62 (patch) | |
tree | 91a8bd0bc379c195d906d0253475977679d7e628 | |
parent | b72e69e52958ca4f381ef1f4a6f2130a7a31f4bf (diff) | |
download | cpython-933209689e8d07e3ce00c68ca26e001b130f0b62.zip cpython-933209689e8d07e3ce00c68ca26e001b130f0b62.tar.gz cpython-933209689e8d07e3ce00c68ca26e001b130f0b62.tar.bz2 |
Issue #20311: Revert 033137c12d88, select.epoll.poll() rounds again the timeout
towards zero
-rw-r--r-- | Lib/test/test_epoll.py | 11 | ||||
-rw-r--r-- | Misc/NEWS | 6 | ||||
-rw-r--r-- | Modules/selectmodule.c | 4 |
3 files changed, 2 insertions, 19 deletions
diff --git a/Lib/test/test_epoll.py b/Lib/test/test_epoll.py index 46d2968..871efb2 100644 --- a/Lib/test/test_epoll.py +++ b/Lib/test/test_epoll.py @@ -217,17 +217,6 @@ class TestEPoll(unittest.TestCase): server.close() ep.unregister(fd) - def test_timeout_rounding(self): - # epoll_wait() has a resolution of 1 millisecond, check if the timeout - # is correctly rounded to the upper bound - epoll = select.epoll() - self.addCleanup(epoll.close) - for timeout in (1e-2, 1e-3, 1e-4): - t0 = time.monotonic() - epoll.poll(timeout) - dt = time.monotonic() - t0 - self.assertGreaterEqual(dt, timeout) - def test_main(): support.run_unittest(TestEPoll) @@ -58,10 +58,6 @@ Library - Issue #20374: Fix build with GNU readline >= 6.3. -- Issue #20311: select.epoll.poll() now rounds the timeout away from zero, - instead of rounding towards zero. For example, a timeout of one microsecond - is now rounded to one millisecond, instead of being rounded to zero. - - Issue #20262: Warnings are raised now when duplicate names are added in the ZIP file or too long ZIP file comment is truncated. @@ -278,7 +274,7 @@ IDLE --Issue #17390: Add Python version to Idle editor window title bar. Original patches by Edmond Burnett and Kent Johnson. - + - Issue #18960: IDLE now ignores the source encoding declaration on the second line if the first line contains anything except a comment. diff --git a/Modules/selectmodule.c b/Modules/selectmodule.c index ab2016a..c492224 100644 --- a/Modules/selectmodule.c +++ b/Modules/selectmodule.c @@ -1379,9 +1379,7 @@ pyepoll_poll(pyEpoll_Object *self, PyObject *args, PyObject *kwds) return NULL; } else { - /* epoll_wait() has a resolution of 1 millisecond, round away from zero - to wait *at least* dtimeout seconds. */ - timeout = (int)ceil(dtimeout * 1000.0); + timeout = (int)(dtimeout * 1000.0); } if (maxevents == -1) { |