diff options
| author | Zackery Spytz <zspytz@gmail.com> | 2019-03-22 07:24:34 (GMT) |
|---|---|---|
| committer | Serhiy Storchaka <storchaka@gmail.com> | 2019-03-22 07:24:34 (GMT) |
| commit | 93e8012f2cabd84f30b52e19fd3dc557efa9f8af (patch) | |
| tree | 14a35ffb5655903a9ca74571996c604f5debe4a2 | |
| parent | 9a0000d15d27361eaa47b77600c7c00a9787a894 (diff) | |
| download | cpython-93e8012f2cabd84f30b52e19fd3dc557efa9f8af.zip cpython-93e8012f2cabd84f30b52e19fd3dc557efa9f8af.tar.gz cpython-93e8012f2cabd84f30b52e19fd3dc557efa9f8af.tar.bz2 | |
bpo-36398: Fix a possible crash in structseq_repr(). (GH-12492)
If the first PyUnicode_DecodeUTF8() call fails in structseq_repr(),
_PyUnicodeWriter_Dealloc() will be called on an uninitialized
_PyUnicodeWriter.
| -rw-r--r-- | Misc/NEWS.d/next/Core and Builtins/2019-03-21-22-19-38.bpo-36398.B_jXGe.rst | 1 | ||||
| -rw-r--r-- | Objects/structseq.c | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/Misc/NEWS.d/next/Core and Builtins/2019-03-21-22-19-38.bpo-36398.B_jXGe.rst b/Misc/NEWS.d/next/Core and Builtins/2019-03-21-22-19-38.bpo-36398.B_jXGe.rst new file mode 100644 index 0000000..2b00283 --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2019-03-21-22-19-38.bpo-36398.B_jXGe.rst @@ -0,0 +1 @@ +Fix a possible crash in ``structseq_repr()``. diff --git a/Objects/structseq.c b/Objects/structseq.c index 5278313..cf36fa7 100644 --- a/Objects/structseq.c +++ b/Objects/structseq.c @@ -176,7 +176,7 @@ structseq_repr(PyStructSequence *obj) strlen(typ->tp_name), NULL); if (type_name == NULL) { - goto error; + return NULL; } _PyUnicodeWriter_Init(&writer); |