summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBarry Warsaw <barry@python.org>2010-03-01 21:53:00 (GMT)
committerBarry Warsaw <barry@python.org>2010-03-01 21:53:00 (GMT)
commitb193826078c72e509549a607a7e9662549ab82a4 (patch)
tree7192e3da4c1fd9cbb81e05b57ffeb59eb1244d4e
parent2a1c0275444bcc1bfd0001e58526530b5138efe4 (diff)
downloadcpython-b193826078c72e509549a607a7e9662549ab82a4.zip
cpython-b193826078c72e509549a607a7e9662549ab82a4.tar.gz
cpython-b193826078c72e509549a607a7e9662549ab82a4.tar.bz2
Manually copy patch for bug 7250 from the release26-maint branch. I suck
because I did this in the wrong order and couldn't smack svnmerge into submission.
-rw-r--r--Lib/wsgiref/handlers.py4
-rw-r--r--Misc/NEWS3
2 files changed, 7 insertions, 0 deletions
diff --git a/Lib/wsgiref/handlers.py b/Lib/wsgiref/handlers.py
index f0cc398..a87c32c 100644
--- a/Lib/wsgiref/handlers.py
+++ b/Lib/wsgiref/handlers.py
@@ -431,6 +431,10 @@ class CGIHandler(BaseCGIHandler):
"""
wsgi_run_once = True
+ # Do not allow os.environ to leak between requests in Google App Engine
+ # and other multi-run CGI use cases. This is not easily testable.
+ # See http://bugs.python.org/issue7250
+ os_environ = {}
def __init__(self):
BaseCGIHandler.__init__(
diff --git a/Misc/NEWS b/Misc/NEWS
index 0ae3867..f2c9bc2 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -262,6 +262,9 @@ C-API
Library
-------
+- Issue #7250: Fix info leak of os.environ across multi-run uses of
+ wsgiref.handlers.CGIHandler.
+
- Issue #1729305: Fix doctest to handle encode error with "backslashreplace".
- Issue #691291: codecs.open() should not convert end of lines on reading and