summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictor Stinner <vstinner@redhat.com>2019-06-04 17:03:13 (GMT)
committerGitHub <noreply@github.com>2019-06-04 17:03:13 (GMT)
commitbc6469f79ca13217b784fb47da7ec83484a3debe (patch)
treeb39ddd93a75009b095258d3ccd8eacdfbf23009c
parent8d0ef0b5edeae52960c7ed05ae8a12388324f87e (diff)
downloadcpython-bc6469f79ca13217b784fb47da7ec83484a3debe.zip
cpython-bc6469f79ca13217b784fb47da7ec83484a3debe.tar.gz
cpython-bc6469f79ca13217b784fb47da7ec83484a3debe.tar.bz2
bpo-37153: test_venv.test_mutiprocessing() calls pool.terminate() (GH-13816)
test_venv.test_mutiprocessing() now explicitly calls pool.terminate() to wait until the pool completes.
-rw-r--r--Lib/test/test_venv.py6
-rw-r--r--Misc/NEWS.d/next/Tests/2019-06-04-18-30-39.bpo-37153.711INB.rst2
2 files changed, 6 insertions, 2 deletions
diff --git a/Lib/test/test_venv.py b/Lib/test/test_venv.py
index 278c686..24d3a69 100644
--- a/Lib/test/test_venv.py
+++ b/Lib/test/test_venv.py
@@ -325,8 +325,10 @@ class BasicTest(BaseTest):
envpy = os.path.join(os.path.realpath(self.env_dir),
self.bindir, self.exe)
out, err = check_output([envpy, '-c',
- 'from multiprocessing import Pool; ' +
- 'print(Pool(1).apply_async("Python".lower).get(3))'])
+ 'from multiprocessing import Pool; '
+ 'pool = Pool(1); '
+ 'print(pool.apply_async("Python".lower).get(3)); '
+ 'pool.terminate()'])
self.assertEqual(out.strip(), "python".encode())
@requireVenvCreate
diff --git a/Misc/NEWS.d/next/Tests/2019-06-04-18-30-39.bpo-37153.711INB.rst b/Misc/NEWS.d/next/Tests/2019-06-04-18-30-39.bpo-37153.711INB.rst
new file mode 100644
index 0000000..138a22f
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2019-06-04-18-30-39.bpo-37153.711INB.rst
@@ -0,0 +1,2 @@
+``test_venv.test_mutiprocessing()`` now explicitly calls
+``pool.terminate()`` to wait until the pool completes.