diff options
author | Steve Dower <steve.dower@microsoft.com> | 2017-02-04 22:54:56 (GMT) |
---|---|---|
committer | Steve Dower <steve.dower@microsoft.com> | 2017-02-04 22:54:56 (GMT) |
commit | d3c4853b7869b347462343fd9df99f998e0eb018 (patch) | |
tree | a57a8027f52185ab3abf65040e694306e3668163 | |
parent | 7e10dbbd45503268f7bb3b241e30745df6c91b99 (diff) | |
download | cpython-d3c4853b7869b347462343fd9df99f998e0eb018.zip cpython-d3c4853b7869b347462343fd9df99f998e0eb018.tar.gz cpython-d3c4853b7869b347462343fd9df99f998e0eb018.tar.bz2 |
Issue #29416: Prevent infinite loop in pathlib.Path.mkdir
-rw-r--r-- | Lib/pathlib.py | 2 | ||||
-rw-r--r-- | Lib/test/test_pathlib.py | 11 | ||||
-rw-r--r-- | Misc/NEWS | 2 |
3 files changed, 14 insertions, 1 deletions
diff --git a/Lib/pathlib.py b/Lib/pathlib.py index 1480e2f..c0d858e 100644 --- a/Lib/pathlib.py +++ b/Lib/pathlib.py @@ -1222,7 +1222,7 @@ class Path(PurePath): if not exist_ok or not self.is_dir(): raise except OSError as e: - if e.errno != ENOENT: + if e.errno != ENOENT or self.parent == self: raise self.parent.mkdir(parents=True) self._accessor.mkdir(self, mode) diff --git a/Lib/test/test_pathlib.py b/Lib/test/test_pathlib.py index fa96d9f..28e3ea4 100644 --- a/Lib/test/test_pathlib.py +++ b/Lib/test/test_pathlib.py @@ -1727,6 +1727,17 @@ class _BasePathTest(object): self.assertTrue(p.exists()) self.assertEqual(p.stat().st_ctime, st_ctime_first) + @only_nt # XXX: not sure how to test this on POSIX + def test_mkdir_with_unknown_drive(self): + for d in 'ZYXWVUTSRQPONMLKJIHGFEDCBA': + p = self.cls(d + ':\\') + if not p.is_dir(): + break + else: + self.skipTest("cannot find a drive that doesn't exist") + with self.assertRaises(OSError): + (p / 'child' / 'path').mkdir(parents=True) + def test_mkdir_with_child_file(self): p = self.cls(BASE, 'dirB', 'fileB') self.assertTrue(p.exists()) @@ -21,6 +21,8 @@ Extension Modules Library ------- +- Issue #29416: Prevent infinite loop in pathlib.Path.mkdir + - Issue #29444: Fixed out-of-bounds buffer access in the group() method of the match object. Based on patch by WGH. |