summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictor Stinner <vstinner@python.org>2023-09-26 00:07:12 (GMT)
committerGitHub <noreply@github.com>2023-09-26 00:07:12 (GMT)
commite5186c3de4194de3ea8c80edb182d786f5e20944 (patch)
tree9ee646ceb2f761028d4b870d304aadf2d25d8baf
parente9791ba35175171170ff09094ea46b91fc18c654 (diff)
downloadcpython-e5186c3de4194de3ea8c80edb182d786f5e20944.zip
cpython-e5186c3de4194de3ea8c80edb182d786f5e20944.tar.gz
cpython-e5186c3de4194de3ea8c80edb182d786f5e20944.tar.bz2
gh-109401: Fix threading barrier test_default_timeout() (#109875)
Increase timeouts. Barrier default timeout should be long enough to spawn 4 threads on a slow CI.
-rw-r--r--Lib/test/lock_tests.py10
1 files changed, 6 insertions, 4 deletions
diff --git a/Lib/test/lock_tests.py b/Lib/test/lock_tests.py
index a4f52cb..0890ec8 100644
--- a/Lib/test/lock_tests.py
+++ b/Lib/test/lock_tests.py
@@ -1014,13 +1014,15 @@ class BarrierTests(BaseTestCase):
"""
Test the barrier's default timeout
"""
- # create a barrier with a low default timeout
- barrier = self.barriertype(self.N, timeout=0.3)
+ # gh-109401: Barrier timeout should be long enough
+ # to create 4 threads on a slow CI.
+ timeout = 1.0
+ barrier = self.barriertype(self.N, timeout=timeout)
def f():
i = barrier.wait()
if i == self.N // 2:
- # One thread is later than the default timeout of 0.3s.
- time.sleep(1.0)
+ # One thread is later than the default timeout.
+ time.sleep(timeout * 2)
self.assertRaises(threading.BrokenBarrierError, barrier.wait)
self.run_threads(f)