diff options
| author | Kyle Stanley <aeros167@gmail.com> | 2020-01-31 20:07:09 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-01-31 20:07:09 (GMT) |
| commit | f03a8f8d5001963ad5b5b28dbd95497e9cc15596 (patch) | |
| tree | d565dc84e788df577d75f328c4c5afb0379046c6 | |
| parent | 58a4054760bffbb20aff90290dd0f3554f7bea42 (diff) | |
| download | cpython-f03a8f8d5001963ad5b5b28dbd95497e9cc15596.zip cpython-f03a8f8d5001963ad5b5b28dbd95497e9cc15596.tar.gz cpython-f03a8f8d5001963ad5b5b28dbd95497e9cc15596.tar.bz2 | |
bpo-37224: Improve test__xxsubinterpreters.DestroyTests (GH-18058)
Adds an additional assertion check based on a race condition for `test__xxsubinterpreters.DestroyTests.test_still_running` discovered in the bpo issue.
https://bugs.python.org/issue37224
| -rw-r--r-- | Lib/test/test__xxsubinterpreters.py | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/Lib/test/test__xxsubinterpreters.py b/Lib/test/test__xxsubinterpreters.py index 207b5db..30f8f98 100644 --- a/Lib/test/test__xxsubinterpreters.py +++ b/Lib/test/test__xxsubinterpreters.py @@ -759,7 +759,11 @@ class DestroyTests(TestBase): main, = interpreters.list_all() interp = interpreters.create() with _running(interp): - with self.assertRaises(RuntimeError): + self.assertTrue(interpreters.is_running(interp), + msg=f"Interp {interp} should be running before destruction.") + + with self.assertRaises(RuntimeError, + msg=f"Should not be able to destroy interp {interp} while it's still running."): interpreters.destroy(interp) self.assertTrue(interpreters.is_running(interp)) |