diff options
| author | Nikita Sobolev <mail@sobolevn.me> | 2022-01-19 21:24:27 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-01-19 21:24:27 (GMT) |
| commit | 263c0dd16017613c5ea2fbfc270be4de2b41b5ad (patch) | |
| tree | 8bee7505b6964861a94ee4adf578639b1e108dfa | |
| parent | 4b99803b861e58eb476a7a30e2e8aacdec5df104 (diff) | |
| download | cpython-263c0dd16017613c5ea2fbfc270be4de2b41b5ad.zip cpython-263c0dd16017613c5ea2fbfc270be4de2b41b5ad.tar.gz cpython-263c0dd16017613c5ea2fbfc270be4de2b41b5ad.tar.bz2 | |
bpo-46437: remove useless `hasattr` from `test_typing` (#30704)
| -rw-r--r-- | Lib/test/test_typing.py | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/Lib/test/test_typing.py b/Lib/test/test_typing.py index 8d02451..ce0c940 100644 --- a/Lib/test/test_typing.py +++ b/Lib/test/test_typing.py @@ -3513,11 +3513,10 @@ class CollectionsAbcTests(BaseTestCase): self.assertNotIsInstance(42, typing.Container) def test_collection(self): - if hasattr(typing, 'Collection'): - self.assertIsInstance(tuple(), typing.Collection) - self.assertIsInstance(frozenset(), typing.Collection) - self.assertIsSubclass(dict, typing.Collection) - self.assertNotIsInstance(42, typing.Collection) + self.assertIsInstance(tuple(), typing.Collection) + self.assertIsInstance(frozenset(), typing.Collection) + self.assertIsSubclass(dict, typing.Collection) + self.assertNotIsInstance(42, typing.Collection) def test_abstractset(self): self.assertIsInstance(set(), typing.AbstractSet) @@ -5130,8 +5129,9 @@ class AllTests(BaseTestCase): self.assertIn('ValuesView', a) self.assertIn('cast', a) self.assertIn('overload', a) - if hasattr(contextlib, 'AbstractContextManager'): - self.assertIn('ContextManager', a) + # Context managers. + self.assertIn('ContextManager', a) + self.assertIn('AsyncContextManager', a) # Check that io and re are not exported. self.assertNotIn('io', a) self.assertNotIn('re', a) @@ -5145,8 +5145,6 @@ class AllTests(BaseTestCase): self.assertIn('SupportsComplex', a) def test_all_exported_names(self): - import typing - actual_all = set(typing.__all__) computed_all = { k for k, v in vars(typing).items() |