summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGregory P. Smith <greg@krypto.org>2021-10-09 19:34:13 (GMT)
committerGitHub <noreply@github.com>2021-10-09 19:34:13 (GMT)
commit3d1ca867ed0e3ae343166806f8ddd9739e568ab4 (patch)
treedc2c9f5d02e164d7b07644c879e512f01efde916
parent5b4a7675bcfc6368aff955f4a6231579718f5dad (diff)
downloadcpython-3d1ca867ed0e3ae343166806f8ddd9739e568ab4.zip
cpython-3d1ca867ed0e3ae343166806f8ddd9739e568ab4.tar.gz
cpython-3d1ca867ed0e3ae343166806f8ddd9739e568ab4.tar.bz2
bpo-45353: Remind sys.modules users to copy when iterating. (GH-28842)
This is true of all dictionaries in Python, but this one tends to catch people off guard as they don't realize when sys.modules might change out from underneath them as a hidden side effect of their code. Copying it first avoids the RuntimeError. An example when this happens in single threaded code are codecs being loaded which are an implicit time of use import that most need not think about.
-rw-r--r--Doc/library/sys.rst6
1 files changed, 5 insertions, 1 deletions
diff --git a/Doc/library/sys.rst b/Doc/library/sys.rst
index ec12e02..8b3c6fd 100644
--- a/Doc/library/sys.rst
+++ b/Doc/library/sys.rst
@@ -1073,7 +1073,11 @@ always available.
This is a dictionary that maps module names to modules which have already been
loaded. This can be manipulated to force reloading of modules and other tricks.
However, replacing the dictionary will not necessarily work as expected and
- deleting essential items from the dictionary may cause Python to fail.
+ deleting essential items from the dictionary may cause Python to fail. If
+ you want to iterate over this global dictionary always use
+ ``sys.modules.copy()`` or ``tuple(sys.modules)`` to avoid exceptions as its
+ size may change during iteration as a side effect of code or activity in
+ other threads.
.. data:: orig_argv