diff options
author | Richard Oudkerk <shibturn@gmail.com> | 2013-06-10 14:38:54 (GMT) |
---|---|---|
committer | Richard Oudkerk <shibturn@gmail.com> | 2013-06-10 14:38:54 (GMT) |
commit | 409f90237c07d2365f6e0b527071e74415c073f3 (patch) | |
tree | 67c2de474717185c2d2981f0ff9b8ca9823b6e9b | |
parent | a822d366750ea0817276f35fd3adcd894472a70a (diff) | |
download | cpython-409f90237c07d2365f6e0b527071e74415c073f3.zip cpython-409f90237c07d2365f6e0b527071e74415c073f3.tar.gz cpython-409f90237c07d2365f6e0b527071e74415c073f3.tar.bz2 |
Issue #18180: Fix ref leak in _PyImport_GetDynLoadWindows().
-rw-r--r-- | Misc/NEWS | 2 | ||||
-rw-r--r-- | Python/dynload_win.c | 5 |
2 files changed, 5 insertions, 2 deletions
@@ -12,6 +12,8 @@ What's New in Python 3.3.3 release candidate 1? Core and Builtins ----------------- +- Issue #18180: Fix ref leak in _PyImport_GetDynLoadWindows(). + - Issue #18038: SyntaxError raised during compilation sources with illegal encoding now always contains an encoding name. diff --git a/Python/dynload_win.c b/Python/dynload_win.c index edb6038..ffcf0ee 100644 --- a/Python/dynload_win.c +++ b/Python/dynload_win.c @@ -262,8 +262,9 @@ dl_funcptr _PyImport_GetDynLoadWindows(const char *shortname, theLength)); } if (message != NULL) { - PyErr_SetImportError(message, PyUnicode_FromString(shortname), - pathname); + PyObject *shortname_obj = PyUnicode_FromString(shortname); + PyErr_SetImportError(message, shortname_obj, pathname); + Py_XDECREF(shortname_obj); Py_DECREF(message); } return NULL; |