summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVictor Stinner <vstinner@python.org>2021-10-07 11:47:23 (GMT)
committerGitHub <noreply@github.com>2021-10-07 11:47:23 (GMT)
commit4e605666b08b8f863cbbbdaa34bb06988e648d26 (patch)
treef6b2f1369c1d634b3bf9cc8b59ec7ffc9edd91e0
parent3f2c433da560d7999a52f9fcba4bbd0898848520 (diff)
downloadcpython-4e605666b08b8f863cbbbdaa34bb06988e648d26.zip
cpython-4e605666b08b8f863cbbbdaa34bb06988e648d26.tar.gz
cpython-4e605666b08b8f863cbbbdaa34bb06988e648d26.tar.bz2
bpo-45400: Fix suggestion test of test_exceptions (GH-28783)
Fix test_name_error_suggestions_do_not_trigger_for_too_many_locals() of test_exceptions if a directory name contains "a1" (like "Python-3.11.0a1"): use a stricter regular expression.
-rw-r--r--Lib/test/test_exceptions.py2
-rw-r--r--Misc/NEWS.d/next/Tests/2021-10-07-13-11-45.bpo-45400.h3iT7V.rst3
2 files changed, 4 insertions, 1 deletions
diff --git a/Lib/test/test_exceptions.py b/Lib/test/test_exceptions.py
index 2892884..85dc3c0 100644
--- a/Lib/test/test_exceptions.py
+++ b/Lib/test/test_exceptions.py
@@ -1840,7 +1840,7 @@ class NameErrorTests(unittest.TestCase):
with support.captured_stderr() as err:
sys.__excepthook__(*sys.exc_info())
- self.assertNotIn("a1", err.getvalue())
+ self.assertNotRegex(err.getvalue(), r"NameError.*a1")
def test_name_error_with_custom_exceptions(self):
def f():
diff --git a/Misc/NEWS.d/next/Tests/2021-10-07-13-11-45.bpo-45400.h3iT7V.rst b/Misc/NEWS.d/next/Tests/2021-10-07-13-11-45.bpo-45400.h3iT7V.rst
new file mode 100644
index 0000000..61b6653
--- /dev/null
+++ b/Misc/NEWS.d/next/Tests/2021-10-07-13-11-45.bpo-45400.h3iT7V.rst
@@ -0,0 +1,3 @@
+Fix test_name_error_suggestions_do_not_trigger_for_too_many_locals() of
+test_exceptions if a directory name contains "a1" (like "Python-3.11.0a1"):
+use a stricter regular expression. Patch by Victor Stinner.