diff options
| author | Steve Dower <steve.dower@python.org> | 2024-04-03 22:14:55 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-04-03 22:14:55 (GMT) |
| commit | 985917dc8d34e2d2f717f7a981580a8dcf18d53a (patch) | |
| tree | 7374deaee1027b81d9c45b3e10f2ed26c8fb012c | |
| parent | 2057c92125f2e37caee209f032be9fe9c208357b (diff) | |
| download | cpython-985917dc8d34e2d2f717f7a981580a8dcf18d53a.zip cpython-985917dc8d34e2d2f717f7a981580a8dcf18d53a.tar.gz cpython-985917dc8d34e2d2f717f7a981580a8dcf18d53a.tar.bz2 | |
gh-117267: Ensure DirEntry.stat().st_ctime still contains creation time during deprecation period (GH-117354)
| -rw-r--r-- | Misc/NEWS.d/next/Windows/2024-03-28-22-12-00.gh-issue-117267.K_tki1.rst | 5 | ||||
| -rw-r--r-- | Modules/posixmodule.c | 4 |
2 files changed, 9 insertions, 0 deletions
diff --git a/Misc/NEWS.d/next/Windows/2024-03-28-22-12-00.gh-issue-117267.K_tki1.rst b/Misc/NEWS.d/next/Windows/2024-03-28-22-12-00.gh-issue-117267.K_tki1.rst new file mode 100644 index 0000000..d322142 --- /dev/null +++ b/Misc/NEWS.d/next/Windows/2024-03-28-22-12-00.gh-issue-117267.K_tki1.rst @@ -0,0 +1,5 @@ +Ensure ``DirEntry.stat().st_ctime`` behaves consistently with +:func:`os.stat` during the deprecation period of ``st_ctime`` by containing +the same value as ``st_birthtime``. After the deprecation period, +``st_ctime`` will be the metadata change time (or unavailable through +``DirEntry``), and only ``st_birthtime`` will contain the creation time. diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c index fcac3db..5e54cf6 100644 --- a/Modules/posixmodule.c +++ b/Modules/posixmodule.c @@ -15830,6 +15830,10 @@ DirEntry_from_find_data(PyObject *module, path_t *path, WIN32_FIND_DATAW *dataW) find_data_to_file_info(dataW, &file_info, &reparse_tag); _Py_attribute_data_to_stat(&file_info, reparse_tag, NULL, NULL, &entry->win32_lstat); + /* ctime is only deprecated from 3.12, so we copy birthtime across */ + entry->win32_lstat.st_ctime = entry->win32_lstat.st_birthtime; + entry->win32_lstat.st_ctime_nsec = entry->win32_lstat.st_birthtime_nsec; + return (PyObject *)entry; error: |