diff options
author | Gregory P. Smith <greg@krypto.org> | 2013-02-01 21:08:23 (GMT) |
---|---|---|
committer | Gregory P. Smith <greg@krypto.org> | 2013-02-01 21:08:23 (GMT) |
commit | 99ec7f6f3ec2bad516faa34afb18e01637011127 (patch) | |
tree | efe0ab76e7390da0ff78c696ea40da22e6782f06 | |
parent | 193e1be72d2f9bb45e054b38dd9ed1090c45f3bf (diff) | |
parent | b9817b01edfe6fa369c4c291a5de00732b8abc7c (diff) | |
download | cpython-99ec7f6f3ec2bad516faa34afb18e01637011127.zip cpython-99ec7f6f3ec2bad516faa34afb18e01637011127.tar.gz cpython-99ec7f6f3ec2bad516faa34afb18e01637011127.tar.bz2 |
Additional fix for issue #12268: The io module file object write methods no
longer abort early when a write system call is interrupted (EINTR).
-rw-r--r-- | Misc/NEWS | 6 | ||||
-rw-r--r-- | Modules/_io/iobase.c | 5 | ||||
-rw-r--r-- | Modules/_io/textio.c | 7 |
3 files changed, 15 insertions, 3 deletions
@@ -506,6 +506,12 @@ Library - Issue #15906: Fix a regression in `argparse` caused by the preceding change, when ``action='append'``, ``type='str'`` and ``default=[]``. +Extension Modules +----------------- + +- Issue #12268: The io module file object write methods no longer abort early + when one of its write system calls is interrupted (EINTR). + Tests ----- diff --git a/Modules/_io/iobase.c b/Modules/_io/iobase.c index babb019..2039147 100644 --- a/Modules/_io/iobase.c +++ b/Modules/_io/iobase.c @@ -669,7 +669,10 @@ iobase_writelines(PyObject *self, PyObject *args) break; /* Stop Iteration */ } - res = PyObject_CallMethodObjArgs(self, _PyIO_str_write, line, NULL); + res = NULL; + do { + res = PyObject_CallMethodObjArgs(self, _PyIO_str_write, line, NULL); + } while (res == NULL && _PyIO_trap_eintr()); Py_DECREF(line); if (res == NULL) { Py_DECREF(iter); diff --git a/Modules/_io/textio.c b/Modules/_io/textio.c index a93049f..ffaa945 100644 --- a/Modules/_io/textio.c +++ b/Modules/_io/textio.c @@ -1247,8 +1247,11 @@ _textiowrapper_writeflush(textio *self) Py_DECREF(pending); if (b == NULL) return -1; - ret = PyObject_CallMethodObjArgs(self->buffer, - _PyIO_str_write, b, NULL); + ret = NULL; + do { + ret = PyObject_CallMethodObjArgs(self->buffer, + _PyIO_str_write, b, NULL); + } while (ret == NULL && _PyIO_trap_eintr()); Py_DECREF(b); if (ret == NULL) return -1; |