diff options
author | Marcel Plch <gmarcel.plch@gmail.com> | 2018-06-15 15:56:24 (GMT) |
---|---|---|
committer | Victor Stinner <vstinner@redhat.com> | 2018-06-15 15:56:24 (GMT) |
commit | 9b7c74ca32d1bec7128d550a9ab1b2ddc7046287 (patch) | |
tree | aac6985467e2b287eb47ab0ba1c04edf433f45fe | |
parent | c1897eda3d47b182977459a1e9fed4b3854a10a0 (diff) | |
download | cpython-9b7c74ca32d1bec7128d550a9ab1b2ddc7046287.zip cpython-9b7c74ca32d1bec7128d550a9ab1b2ddc7046287.tar.gz cpython-9b7c74ca32d1bec7128d550a9ab1b2ddc7046287.tar.bz2 |
bpo-32962: Fix test_gdb failure in debug build with -mcet -fcf-protection -O0 (#6754)
When Python is built with the intel control-flow protection flags,
-mcet -fcf-protection, gdb is not able to read the stack without
actually jumping inside the function. This means an extra
'next' command is required to make the $pc (program counter)
enter the function and make the stack of the function exposed to gdb.
-rw-r--r-- | Lib/test/test_gdb.py | 11 | ||||
-rw-r--r-- | Misc/NEWS.d/next/Tests/2018-05-10-16-59-15.bpo-32962.S-rcIN.rst | 1 |
2 files changed, 10 insertions, 2 deletions
diff --git a/Lib/test/test_gdb.py b/Lib/test/test_gdb.py index 9e0eaea..d341a17 100644 --- a/Lib/test/test_gdb.py +++ b/Lib/test/test_gdb.py @@ -162,7 +162,11 @@ class DebuggerTests(unittest.TestCase): commands += ['set print entry-values no'] if cmds_after_breakpoint: - commands += cmds_after_breakpoint + # bpo-32962: When Python is compiled with -mcet -fcf-protection, + # arguments are unusable before running the first instruction + # of the function entry point. The 'next' command makes the + # required first step. + commands += ['next'] + cmds_after_breakpoint else: commands += ['backtrace'] @@ -847,9 +851,12 @@ id(42) id("first break point") l = MyList() ''') + # bpo-32962: same case as in get_stack_trace(): + # we need an additional 'next' command in order to read + # arguments of the innermost function of the call stack. # Verify with "py-bt": gdb_output = self.get_stack_trace(cmd, - cmds_after_breakpoint=['break wrapper_call', 'continue', 'py-bt']) + cmds_after_breakpoint=['break wrapper_call', 'continue', 'next', 'py-bt']) self.assertRegex(gdb_output, r"<method-wrapper u?'__init__' of MyList object at ") diff --git a/Misc/NEWS.d/next/Tests/2018-05-10-16-59-15.bpo-32962.S-rcIN.rst b/Misc/NEWS.d/next/Tests/2018-05-10-16-59-15.bpo-32962.S-rcIN.rst new file mode 100644 index 0000000..97328eb --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2018-05-10-16-59-15.bpo-32962.S-rcIN.rst @@ -0,0 +1 @@ +Fixed test_gdb when Python is compiled with flags -mcet -fcf-protection -O0. |