diff options
| author | Peter Bierma <zintensitydev@gmail.com> | 2024-09-16 20:03:16 (GMT) |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-09-16 20:03:16 (GMT) |
| commit | 3b45df03a4bd0e21edec43144b8d9bac689d23a0 (patch) | |
| tree | e4a80ab3c8fccedacf0b77abd4fa0b424bb55410 | |
| parent | 44052b5f18c5d605d33bf3207b5c918127cf0e82 (diff) | |
| download | cpython-3b45df03a4bd0e21edec43144b8d9bac689d23a0.zip cpython-3b45df03a4bd0e21edec43144b8d9bac689d23a0.tar.gz cpython-3b45df03a4bd0e21edec43144b8d9bac689d23a0.tar.bz2 | |
gh-124043: Disallow mixing `--with-trace-refs` and `--disable-gil` (#124078)
Tracing references is not currently thread-safe in the free-threaded build.
| -rw-r--r-- | Misc/NEWS.d/next/Build/2024-09-13-17-48-37.gh-issue-124043.Bruxpq.rst | 2 | ||||
| -rwxr-xr-x | configure | 4 | ||||
| -rw-r--r-- | configure.ac | 4 |
3 files changed, 10 insertions, 0 deletions
diff --git a/Misc/NEWS.d/next/Build/2024-09-13-17-48-37.gh-issue-124043.Bruxpq.rst b/Misc/NEWS.d/next/Build/2024-09-13-17-48-37.gh-issue-124043.Bruxpq.rst new file mode 100644 index 0000000..8111b76 --- /dev/null +++ b/Misc/NEWS.d/next/Build/2024-09-13-17-48-37.gh-issue-124043.Bruxpq.rst @@ -0,0 +1,2 @@ +Building using :option:`--with-trace-refs` is (temporarily) disallowed when the +GIL is disabled. @@ -8234,6 +8234,10 @@ printf "%s\n" "#define Py_TRACE_REFS 1" >>confdefs.h fi +if test "$disable_gil" = "yes" -a "$with_trace_refs" = "yes"; +then + as_fn_error $? "--disable-gil cannot be used with --with-trace-refs" "$LINENO" 5 +fi # Check for --enable-pystats { printf "%s\n" "$as_me:${as_lineno-$LINENO}: checking for --enable-pystats" >&5 diff --git a/configure.ac b/configure.ac index 5fc7e08..ab6233a 100644 --- a/configure.ac +++ b/configure.ac @@ -1777,6 +1777,10 @@ then [Define if you want to enable tracing references for debugging purpose]) fi +if test "$disable_gil" = "yes" -a "$with_trace_refs" = "yes"; +then + AC_MSG_ERROR([--disable-gil cannot be used with --with-trace-refs]) +fi # Check for --enable-pystats AC_MSG_CHECKING([for --enable-pystats]) |