diff options
author | Petri Lehtinen <petri@digip.org> | 2012-06-15 18:01:39 (GMT) |
---|---|---|
committer | Petri Lehtinen <petri@digip.org> | 2012-06-15 18:01:56 (GMT) |
commit | a717d563d0807b4c95231fcebfd3fd7b5d567c26 (patch) | |
tree | 8f0c255e57d09ccb60ef2ae0c77306882069e718 | |
parent | 3730a17a58d9058b0880202050a8c1e4ea193e8f (diff) | |
parent | 02653f1b111c8b9f64de8960d9a55d4f5821e257 (diff) | |
download | cpython-a717d563d0807b4c95231fcebfd3fd7b5d567c26.zip cpython-a717d563d0807b4c95231fcebfd3fd7b5d567c26.tar.gz cpython-a717d563d0807b4c95231fcebfd3fd7b5d567c26.tar.bz2 |
#15036: Make a repeated changes and flushes work with single-file mailboxes
-rw-r--r-- | Lib/mailbox.py | 1 | ||||
-rw-r--r-- | Lib/test/test_mailbox.py | 11 | ||||
-rw-r--r-- | Misc/NEWS | 4 |
3 files changed, 16 insertions, 0 deletions
diff --git a/Lib/mailbox.py b/Lib/mailbox.py index 7a29555..d86ad94 100644 --- a/Lib/mailbox.py +++ b/Lib/mailbox.py @@ -675,6 +675,7 @@ class _singlefileMailbox(Mailbox): new_file.write(buffer) new_toc[key] = (new_start, new_file.tell()) self._post_message_hook(new_file) + self._file_length = new_file.tell() except: new_file.close() os.remove(new_file.name) diff --git a/Lib/test/test_mailbox.py b/Lib/test/test_mailbox.py index 0fe4bd9..cb54505 100644 --- a/Lib/test/test_mailbox.py +++ b/Lib/test/test_mailbox.py @@ -504,6 +504,17 @@ class TestMailbox(TestBase): # Write changes to disk self._test_flush_or_close(self._box.flush, True) + def test_popitem_and_flush_twice(self): + # See #15036. + self._box.add(self._template % 0) + self._box.add(self._template % 1) + self._box.flush() + + self._box.popitem() + self._box.flush() + self._box.popitem() + self._box.flush() + def test_lock_unlock(self): # Lock and unlock the mailbox self.assertFalse(os.path.exists(self._get_lock_path())) @@ -21,6 +21,10 @@ Core and Builtins Library ------- +- Issue #15036: Allow removing or changing multiple items in + single-file mailboxes (mbox, MMDF, Babyl) flushing the mailbox + between the changes. + - Issue #14059: Implement multiprocessing.Barrier. - Issue #15061: The inappropriately named hmac.secure_compare has been |