diff options
author | Antoine Pitrou <solipsis@pitrou.net> | 2011-10-18 14:42:55 (GMT) |
---|---|---|
committer | Antoine Pitrou <solipsis@pitrou.net> | 2011-10-18 14:42:55 (GMT) |
commit | cf28eacafe603fac8784d4a0b22b7864aec4a383 (patch) | |
tree | b7b543a8d435b63346424dd7dc951b8fe0430efb | |
parent | 3de134b1d18ab2e74a4093358fd28333eb101f7a (diff) | |
parent | 551ba20e8ea9a4a97cf63f28b47175e084eb63cd (diff) | |
download | cpython-cf28eacafe603fac8784d4a0b22b7864aec4a383.zip cpython-cf28eacafe603fac8784d4a0b22b7864aec4a383.tar.gz cpython-cf28eacafe603fac8784d4a0b22b7864aec4a383.tar.bz2 |
Issue #13188: When called without an explicit traceback argument,
generator.throw() now gets the traceback from the passed exception's
``__traceback__`` attribute. Patch by Petri Lehtinen.
-rw-r--r-- | Lib/test/test_generators.py | 26 | ||||
-rw-r--r-- | Misc/NEWS | 4 | ||||
-rw-r--r-- | Objects/genobject.c | 5 |
3 files changed, 35 insertions, 0 deletions
diff --git a/Lib/test/test_generators.py b/Lib/test/test_generators.py index 3ec209b..5f47b3e 100644 --- a/Lib/test/test_generators.py +++ b/Lib/test/test_generators.py @@ -1673,6 +1673,32 @@ Traceback (most recent call last): ... ValueError: 7 +Plain "raise" inside a generator should preserve the traceback (#13188). +The traceback should have 3 levels: +- g.throw() +- f() +- 1/0 + +>>> def f(): +... try: +... yield +... except: +... raise +>>> g = f() +>>> try: +... 1/0 +... except ZeroDivisionError as v: +... try: +... g.throw(v) +... except Exception as w: +... tb = w.__traceback__ +>>> levels = 0 +>>> while tb: +... levels += 1 +... tb = tb.tb_next +>>> levels +3 + Now let's try closing a generator: >>> def f(): @@ -10,6 +10,10 @@ What's New in Python 3.3 Alpha 1? Core and Builtins ----------------- +- Issue #13188: When called without an explicit traceback argument, + generator.throw() now gets the traceback from the passed exception's + ``__traceback__`` attribute. Patch by Petri Lehtinen. + - Issue #13146: Writing a pyc file is now atomic under POSIX. - Issue #7833: Extension modules built using distutils on Windows will no diff --git a/Objects/genobject.c b/Objects/genobject.c index 43d0335..b7765ef 100644 --- a/Objects/genobject.c +++ b/Objects/genobject.c @@ -261,6 +261,11 @@ gen_throw(PyGenObject *gen, PyObject *args) val = typ; typ = PyExceptionInstance_Class(typ); Py_INCREF(typ); + + if (tb == NULL) { + /* Returns NULL if there's no traceback */ + tb = PyException_GetTraceback(val); + } } } else { |