diff options
author | Antoine Pitrou <solipsis@pitrou.net> | 2012-10-01 21:44:00 (GMT) |
---|---|---|
committer | Antoine Pitrou <solipsis@pitrou.net> | 2012-10-01 21:44:00 (GMT) |
commit | 77cddc316477b002453f4b9e95278b93b3cb3070 (patch) | |
tree | c1f0efad76cddedbaf41c2234fe1fbf8d7cb617d | |
parent | c19488498354cedfec8d4ad3884292d4a5594641 (diff) | |
parent | 219c7b90d0d2e1eda3a76e2d777240c005c658cb (diff) | |
download | cpython-77cddc316477b002453f4b9e95278b93b3cb3070.zip cpython-77cddc316477b002453f4b9e95278b93b3cb3070.tar.gz cpython-77cddc316477b002453f4b9e95278b93b3cb3070.tar.bz2 |
Merge
-rw-r--r-- | Lib/bz2.py | 24 | ||||
-rw-r--r-- | Lib/test/test_threaded_import.py | 4 |
2 files changed, 13 insertions, 15 deletions
@@ -159,21 +159,18 @@ class BZ2File(io.BufferedIOBase): raise ValueError("I/O operation on closed file") def _check_can_read(self): - if self.closed: - raise ValueError("I/O operation on closed file") if self._mode not in (_MODE_READ, _MODE_READ_EOF): + self._check_not_closed() raise io.UnsupportedOperation("File not open for reading") def _check_can_write(self): - if self.closed: - raise ValueError("I/O operation on closed file") if self._mode != _MODE_WRITE: + self._check_not_closed() raise io.UnsupportedOperation("File not open for writing") def _check_can_seek(self): - if self.closed: - raise ValueError("I/O operation on closed file") if self._mode not in (_MODE_READ, _MODE_READ_EOF): + self._check_not_closed() raise io.UnsupportedOperation("Seeking is only supported " "on files open for reading") if not self._fp.seekable(): @@ -322,10 +319,12 @@ class BZ2File(io.BufferedIOBase): non-negative, no more than size bytes will be read (in which case the line may be incomplete). Returns b'' if already at EOF. """ - if not hasattr(size, "__index__"): - raise TypeError("Integer argument expected") - size = size.__index__() + if not isinstance(size, int): + if not hasattr(size, "__index__"): + raise TypeError("Integer argument expected") + size = size.__index__() with self._lock: + self._check_can_read() # Shortcut for the common case - the whole line is in the buffer. if size < 0: end = self._buffer.find(b"\n", self._buffer_offset) + 1 @@ -343,9 +342,10 @@ class BZ2File(io.BufferedIOBase): further lines will be read once the total size of the lines read so far equals or exceeds size. """ - if not hasattr(size, "__index__"): - raise TypeError("Integer argument expected") - size = size.__index__() + if not isinstance(size, int): + if not hasattr(size, "__index__"): + raise TypeError("Integer argument expected") + size = size.__index__() with self._lock: return io.BufferedIOBase.readlines(self, size) diff --git a/Lib/test/test_threaded_import.py b/Lib/test/test_threaded_import.py index 4a5d7be..0528b13 100644 --- a/Lib/test/test_threaded_import.py +++ b/Lib/test/test_threaded_import.py @@ -225,11 +225,9 @@ class ThreadedImportTests(unittest.TestCase): @reap_threads def test_main(): old_switchinterval = None - # Issue #15599: FreeBSD/KVM cannot handle gil_interval == 1. - new_switchinterval = 0.00001 if 'freebsd' in sys.platform else 0.00000001 try: old_switchinterval = sys.getswitchinterval() - sys.setswitchinterval(new_switchinterval) + sys.setswitchinterval(1e-5) except AttributeError: pass try: |